Skip to content

Conversation

@karlduderstadt
Copy link
Contributor

This change will prevent confusion with the new Python (PyImageJ)
language.

This change is required for autocompletion to work with the
renamed language in scripting-jython
scijava/scripting-jython@07dc8b0

This change will prevent confusion with the new Python (PyImageJ)
language. This change is required for autocompletion to work with the
renamed language in scripting-jython
scijava/scripting-jython@07dc8b0
@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/python-syntax-highlighting-stopped-working-in-fiji-script-editor/83615/3

@ctrueden ctrueden added this to the next-release milestone Jul 15, 2023
@tferr
Copy link
Collaborator

tferr commented Jan 19, 2024

@ctrueden , @karlduderstadt : This is causing major disruptions because without it jython autocompletions don't work. I know this is planned for the next release, but unless that is imminent , I would merge this now. I have bandwidth to do it. I could:

  1. Merge and push the current SNAPSHOT to the java8 update site, or
  2. Merge, cut a new release, and push that to the java8 update site

Let me know what you prefer/would be best..

EDIT: Oh, I just read with more detail the discussion in the forum post. I see now that more refactoring is planned, sorry for missing it. Either way, let me know how can I help, and/or if my proposals above can be used as a stop-gap

@acardona
Copy link
Collaborator

acardona commented Jan 19, 2024 via email

@karlduderstadt
Copy link
Contributor Author

Sounds great to me! I would have done it myself, but I don't have access to those update sites. I am really sorry for all the trouble. Would be great to have the fix now. The refactoring can happen later.

@ctrueden ctrueden merged commit 56f3886 into main Jan 19, 2024
@ctrueden ctrueden deleted the Rename_language_to_Python_(Jython) branch January 19, 2024 19:35
@ctrueden
Copy link
Member

ctrueden commented Jan 19, 2024

I released script-editor-jython v1.0.1 including this change, and updated the version in pom-scijava (scijava/pom-scijava@1fd6bd2). I was going upload it as a hot-fix to the core Java-8 update site to end the suffering, but in a quick test just now, this change does not actually fix the Jython syntax highlighting in the Script Editor for me. What am I forgetting?

@karlduderstadt
Copy link
Contributor Author

karlduderstadt commented Jan 19, 2024

Thanks @ctrueden! For it to work the other PR in scripting-jython scijava/scripting-jython#12 also needs to be merged and released that actually adds the highlighter. This only renames the scripting language for the autocompletion. I included both in my post on the forum https://forum.image.sc/t/python-syntax-highlighting-stopped-working-in-fiji-script-editor/83615/3

@ctrueden
Copy link
Member

Thanks for the reminder @karlduderstadt. I moved your JythonScriptSyntaxHighlighter class to script-editor-jython and released another new version, v1.1.0, and uploaded it to the core update site.

@karlduderstadt
Copy link
Contributor Author

Thanks! That makes a lot more sense. I should have done that. Glad this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants