Skip to content

fix #9579: prevent non static enums that extend jl.Enum #9678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2020
Merged

fix #9579: prevent non static enums that extend jl.Enum #9678

merged 2 commits into from
Sep 2, 2020

Conversation

@bishabosha
Copy link
Member

@bishabosha bishabosha commented Aug 28, 2020 •
edited
Loading

I guess the TestSuite example is the most disruptive

fixes #9579

@bishabosha bishabosha requested a review from sjrd August 28, 2020 21:56
sjrd
sjrd requested changes Aug 29, 2020
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a new item in the comment of checkEnum. Otherwise LGTM

@bishabosha bishabosha merged commit 487e69d into scala:master Sep 2, 2020
@bishabosha bishabosha deleted the fix-#9579 branch September 2, 2020 09:57
@griggt griggt mentioned this pull request Sep 25, 2020
Closed
@griggt griggt mentioned this pull request Oct 15, 2020
Merged
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjrd sjrd sjrd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

MatchError at GenBCode with class wrapping java style enum

3 participants

@bishabosha @sjrd @Kordyjan