Add regression tests and close out already fixed fuzzball issues #10007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Oct 15, 2020
Member
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
liufengyun
approved these changes
Oct 19, 2020
Contributor
liufengyun
left a comment
liufengyun
left a comment
There was a problem hiding this comment.
LGTM, thanks @griggt 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add regression tests for the following open fuzzball issues that have already been fixed (either intentionally or incidentally):
#7745 is fixed by 9d158e0 in #9559
#9292 is fixed by 167db24 in #9845
#9330 is fixed by 9d158e0 in #9559
#9331 is fixed by 311e5ce in #9991
#9332 is fixed by 0bac80a in #9678
Note that although #9331 is "fixed" (it shows an error message at the appropriate location rather than crashes),
the error message is not particularly great, see #9331 (comment). Although, package objects are going away...
Closes #7745
Closes #9292
Closes #9330
Closes #9331 ?
Closes #9332