Skip to content

Add missing SuperType in pattern match #4824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Add missing SuperType in pattern match #4824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler/src/dotty/tools/dotc/tastyreflect/TastyImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,7 @@ class TastyImpl(val rootContext: Contexts.Context) extends scala.tasty.Tasty { s
def unapply(x: Pattern)(implicit ctx: Context): Option[Term] = x match {
case lit: tpd.Literal @unchecked => Some(lit)
case ref: tpd.RefTree @unchecked if ref.isTerm => Some(ref)
case ths: tpd.This @unchecked => Some(ths)
Copy link
Contributor

@Blaisorblade Blaisorblade Jul 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have tests for this code?

Copy link
Contributor Author

@nicolasstucki nicolasstucki Jul 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #4645, but it will take some time to be merged.

case _ => None
}
}
Expand Down
2 changes: 2 additions & 0 deletions library/src/scala/tasty/util/ShowExtractors.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,8 @@ class ShowExtractors[T <: Tasty with Singleton](tasty0: T) extends Show[T](tasty
this += "Type.ParamRef(" += binder+= ", " += idx += ")"
case Type.ThisType(tp) =>
this += "Type.ThisType(" += tp += ")"
case Type.SuperType(thistpe, supertpe) =>
this += "Type.SuperType(" += thistpe += ", " += supertpe += ")"
case Type.RecursiveThis(binder) =>
this += "Type.RecursiveThis(" += binder += ")"
case Type.RecursiveType(underlying) =>
Expand Down
4 changes: 4 additions & 0 deletions library/src/scala/tasty/util/ShowSourceCode.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,6 +908,10 @@ class ShowSourceCode[T <: Tasty with Singleton](tasty0: T) extends Show[T](tasty
printType(tp)
}

case Type.SuperType(thistpe, supertpe) =>
printType(supertpe)
this += ".super"

case Type.TypeLambda(paramNames, tparams, body) =>
inSquare(printMethodicTypeParams(paramNames, tparams))
this += " => "
Expand Down