Add FromTastyDecompilation decompilation blacklist

[nicolasstucki]

No description provided.

[nicolasstucki]

With the current blacklist, it tests 1847 decompilations and 633 recompilations

[smarter]

We need some way to automatically update the blacklist, otherwise this will be impossible to maintain. I also suggest maintaining the list in a separate file, and still running the tests on the blacklisted files so we know when something starts to pass.

[nicolasstucki]

This PR adds a blacklist for decompilation tests; this implies that we decompile all tests instead of only the ones that have an explicit XYZ.decompiled file. It also adds a whitelist for recompilation with all the tests that currently work, it is not a blacklist to avoid newly added tests to fail the decompilation tests.

[nicolasstucki]

@allanrenucci could you review this now. Now it is not a wip anymore and it should be merged to have more regression tests.

[allanrenucci]

Instead of having these blacklist/whitelist being passed as functions/Set, I would introduce a unique abstraction. Something like:

sealed trait FileFilter {
  def accept(file: String): Boolean
}

object FileFilter {
  def excludeAll(files: List[String]): FileFilter = new FileFilter {
    private[this] val blackList = files.toSet
    def accept(file: String) = !blackList.contains(file)
  }
  def includeAll(files: List[String]): FileFilter = new FileFilter {
    private[this] val whiteList = files.toSet
    def accept(file: String) = whiteList.contains(file)
  }
  object NoFilter extends FileFilter {
    def accept(file: String) = true
  }
}

[allanrenucci]

Is that supposed to be a comment?

[nicolasstucki]

Yes. These tests fail because they have a Constant(_) (as in Literal(Constant(_))) with a scala.Symbol inside.

[allanrenucci]

Shouldn't a comment start with #?

[nicolasstucki]

Oh, yes

[nicolasstucki]

@allanrenucci, I added the FileFilter

[allanrenucci]

I think I would merge ListOfSources.scala, FromTastySources.scala, StdLibSources.scala into a single file TestRessources or TestSources.

Otherwise LGTM

[allanrenucci]

recompilationBlacklisted?