Skip to content

fix(scaladocs): make sure scaladocs are aligned with actual behavior #17448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2023
Merged

fix(scaladocs): make sure scaladocs are aligned with actual behavior #17448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/plugins/Plugin.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ sealed trait Plugin {
trait StandardPlugin extends Plugin {
/** Non-research plugins should override this method to return the phases
*
* @param options commandline options to the plugin, `-P:plugname:opt1,opt2` becomes List(opt1, opt2)
* @param options commandline options to the plugin.
* @return a list of phases to be added to the phase plan
*/
def init(options: List[String]): List[PluginPhase]
Expand Down
2 changes: 0 additions & 2 deletions compiler/src/dotty/tools/dotc/plugins/Plugins.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ trait Plugins {

/** Add plugin phases to phase plan */
def addPluginPhases(plan: List[List[Phase]])(using Context): List[List[Phase]] = {
// plugin-specific options.
// The user writes `-P:plugname:opt1,opt2`, but the plugin sees `List(opt1, opt2)`.
def options(plugin: Plugin): List[String] = {
def namec = plugin.name + ":"
ctx.settings.pluginOptions.value filter (_ startsWith namec) map (_ stripPrefix namec)
Expand Down