fix(scaladocs): make sure scaladocs are aligned with actual behavior #17448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liufengyun would you be able to review this one? |
ckipp01
force-pushed
the
compilerPluginOptions
branch
from
208d069 to
c9d669f
Compare
This just makes a small update to the scaladocs to align what actually happens with what the comments say. Currently the comments are incorrect as passing in `-P:plugname:opt1,opt2` becomes List(opt1, opt2)` does not become `List(opt1, opt2)`. refs scala#17238
ckipp01
force-pushed
the
compilerPluginOptions
branch
from
c9d669f to
4ffc391
Compare
ckipp01
changed the title
,
liufengyun
approved these changes
May 19, 2023
G1ng3r
pushed a commit
to G1ng3r/dotty
that referenced
this pull request
Sep 10, 2023
…cala#17448) This change just make sure the actual behavior is aligned with the comments about plugin options. refs scala#17238
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change just make sure the actual behavior is aligned with the comments about plugin options.
refs #17238