fix for #13760 - running script compiled jar no longer restricted to java.base module #15103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the problem described in #13760.
The essence of the problem: running a script with the
-saveoption will throw aClassNotFoundException, but only when running from the compiled jar, and only if the script references modules other thanjava.base. The jar is fine when run viajava -jar <jarfile>, the issue only occurs when scala launches the jar.The workaround for the problem has been to append the
-nosaveoption to the hashbang line.The cause of the problem is that
bootClassLoaderin ScalaClassLoader is set tonullwhen running injdk9+.The following command line illustrates the problem code at
ScalaClassLoader line 70:```scala $ /opt/scala3/bin/scala -e 'import java.lang.invoke.*; MethodHandles.lookup().findStatic(classOf[ClassLoader], "getPlatformClassLoader", MethodType.methodType(classOf[ClassLoader])).invoke().asInstan ceOf[ClassLoader]' Exception in thread "main" java.lang.invoke.WrongMethodTypeException: cannot convert MethodHandle()ClassLoader to (Object[])Object at java.base/java.lang.invoke.MethodHandle.asTypeUncached(MethodHandle.java:861) at java.base/java.lang.invoke.MethodHandle.asType(MethodHandle.java:847) at java.base/java.lang.invoke.MethodHandleImpl$WrappedMember.asTypeUncached(MethodHandleImpl.java:1371) at java.base/java.lang.invoke.MethodHandle.asType(MethodHandle.java:847) at java.base/java.lang.invoke.Invokers.checkGenericType(Invokers.java:495) at compileFromString$minus08906c21$minusee54$minus45f1$minusb470$minusfe08bfbca561$package$.main(compileFromString-08906c21-ee54-45f1-b470-fe08bfbca561.scala:2) at main.main(compileFromString-08906c21-ee54-45f1-b470-fe08bfbca561.scala:1) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at dotty.tools.scripting.StringDriver.compileAndRun(StringDriver.scala:36) at dotty.tools.MainGenericRunner$.run$1(MainGenericRunner.scala:257) at dotty.tools.MainGenericRunner$.main(MainGenericRunner.scala:267) at dotty.tools.MainGenericRunner.main(MainGenericRunner.scala) ```An explanation of why this code no longer works for
jdk9+is described here: Regression in behavior of a null parent ClassLoaderThe proposed fix is based on the fix to #11658.