repl: Use the correct parent Classloader on Java 9+ #11658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Java 9+, `null` as a parent of a URLClassLoader means the parent is the bootstrap classloader which doesn't contain modules like `java.sql`, explicitly use the platform classloader instead. Fixes scala#11646.
smarter
force-pushed
the
repl-classloader
branch
from
d11fccb to
4f803eb
Compare
ckipp01
added a commit
to ckipp01/metals
that referenced
this pull request
Mar 25, 2021
Instead of passing in `null` when we extend ClassLoader in our MdocClassLoader this passes in the actual parent since on Java +9 when using `null` that's the bootstrap classloader which doesn't contain modules like java.sql. Bit thanks to @smarter pointing this out in scala/scala3#11658. Fixes scalameta#2187
ckipp01
added a commit
to ckipp01/metals
that referenced
this pull request
Mar 25, 2021
Instead of passing in `null` when we extend ClassLoader in our MdocClassLoader this passes in the actual parent since on Java +9 when using `null` that's the bootstrap classloader which doesn't contain modules like java.sql. Bit thanks to @smarter pointing this out in scala/scala3#11658. Fixes scalameta#2187
ckipp01
added a commit
to ckipp01/metals
that referenced
this pull request
Mar 25, 2021
Instead of passing in `null` when we extend ClassLoader in our MdocClassLoader this passes in the actual parent since on Java +9 when using `null` that's the bootstrap classloader which doesn't contain modules like java.sql. Big thanks to @smarter pointing this out in scala/scala3#11658. Fixes scalameta#2187
ckipp01
added a commit
to ckipp01/metals
that referenced
this pull request
Mar 25, 2021
Instead of passing in `null` when we extend ClassLoader in our MdocClassLoader this passes in the actual parent since on Java +9 when using `null` that's the bootstrap classloader which doesn't contain modules like java.sql. Big thanks to @smarter pointing this out in scala/scala3#11658. Fixes scalameta#2187
This was referenced Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Java 9+,
nullas a parent of a URLClassLoader means the parent isthe bootstrap classloader which doesn't contain modules like
java.sql,explicitly use the system classloader instead.
Fixes #11646.