Fix typo in FromExpr#BooleanFromExpr #11337
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull updates from base repo.
Recover the denotation of constant-folded selections
… Fix names that should be put inside backticks"
remove dottydoc
Scaladoc: Fix links to members inside package objects, links containing hashes and links containg backticks
These call use `java.lang.System.arraycopy` to add the elements
Init: Promote `this` after all its fields have been initialized
Signed-off-by: Iltotore <[email protected]>
Contributor
Author
|
mhh... I don't really understand why tests stopped passing for fixing only a typo Edit for @nicolasstucki : your review seems to be automatically swept when I rebased the branch. |
Contributor
|
@Iltotore maybe it is simpler to just create a new branch/PR from dotty/master and fix the typo again. |
Merged
Contributor
Author
|
@nicolasstucki I re-created a new PR from a fresh new branch. PS: If you don't want to be pinged anymore, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple typo fix in the method comment.