Recover the denotation of constant-folded selections #11373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
changed the title
smarter
force-pushed
the
exp/tasty-symbol
branch
3 times, most recently
from
dab4880 to
226e809
Compare
With this change, the only term selections without a symbol after Typer and before Pickler come from polymorphic function calls or outer selects. This should be good enough to let us use SELECTin in all situations where overloads can appear as scala#11210 is attempting.
odersky
approved these changes
Feb 11, 2021
Contributor
odersky
left a comment
odersky
left a comment
There was a problem hiding this comment.
Nice work. Yes, that should make pickling more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the only term selections without a symbol after Typer and before Pickler
come from polymorphic function calls or outer selects. This should be good enough to let
us use SELECTin in all situations where overloads can appear as #11210
is attempting.