Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Conversation

@am11
Copy link
Contributor

@am11 am11 commented Aug 25, 2014

With this, the travis-ci build doesn't throw seg-fault. ☺️

There are still two test cases failing on Ubuntu and one on Windows.

@mgreter, can you reproduce these? In Windows this test fails as upstream returns:

  sources:
   [ '..\\included_files.scss',
     '..\\sample.scss',
     '..\\image_path.scss' ],

instead of :

  sources:
   [ '../included_files.scss',
     '../sample.scss',
     '../image_path.scss' ],

In Ubuntu, these two tests fail owing to the fact that upstream puts this comment /*# sourceMappingURL=../out.css.map */ in CSS instead of /*# sourceMappingURL=out.css.map */.

andrew pushed a commit that referenced this pull request Aug 26, 2014
Code: Fixed another segmentation fault
@andrew andrew merged commit f88858e into sass:master Aug 26, 2014
@andrew
Copy link
Contributor

andrew commented Aug 26, 2014

Thanks @am11!

@am11
Copy link
Contributor Author

am11 commented Aug 26, 2014

Turned out the Windows issue was due to the post processing of maps in sass.js. #401 fixes it. The Ubuntu issue is fixed in upstream sass/libsass#477.

jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
Use double instead of long to avoid ambiguous error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants