Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Conversation

@am11
Copy link
Contributor

@am11 am11 commented Aug 24, 2014

Fixes #379.

@am11 am11 force-pushed the master branch 3 times, most recently from ab6692d to 9025a2e Compare August 24, 2014 17:55
@andrew
Copy link
Contributor

andrew commented Aug 24, 2014

Might be worth rebasing this against master now that I've updated libsass

@andrew
Copy link
Contributor

andrew commented Aug 24, 2014

It also seems to be failing on node v0.11: https://travis-ci.org/sass/node-sass/jobs/33431077

@am11 am11 force-pushed the master branch 2 times, most recently from 2690c8b to caad14f Compare August 24, 2014 18:16
@am11
Copy link
Contributor Author

am11 commented Aug 24, 2014

@andrew, done. Even without this commit, eight tests are failing. Looks like something has changed in upstream..

To comply with the changes in libsass.
@am11
Copy link
Contributor Author

am11 commented Aug 24, 2014

@mgreter,

When output and map files are in same directory, it produces CSS file with this source-map comment sourceMappingURL=../fileName.css.map as opposed to sourceMappingURL=./fileName.css.map or simply sourceMappingURL=fileName.css.map. We are using libsass' latest master at the moment.

@am11
Copy link
Contributor Author

am11 commented Aug 24, 2014

@andrew, the Travis CI build has passed. There are three tests failing due to the bug reported in previous comment. Should we merge it?

@andrew
Copy link
Contributor

andrew commented Aug 24, 2014

Yeah let's merge it and fix from there.

andrew pushed a commit that referenced this pull request Aug 24, 2014
Binding: Send output path to upstream (#379)
@andrew andrew merged commit a882994 into sass:master Aug 24, 2014
@am11
Copy link
Contributor Author

am11 commented Aug 24, 2014

@mgreter, that was the node-sass issue. Its fixed by b5ca634.

@andrew b5ca634 via #395 is failing with node v0.11. It throws Segmentation fault. I think that is due to some dependency issue with v0.11.

@am11
Copy link
Contributor Author

am11 commented Aug 24, 2014

In my local build with node.js v0.11.9 and npm v1.3.15, node-sass-middleware is looking culprit.

@andrew
Copy link
Contributor

andrew commented Aug 25, 2014

I've updated nan to v1.3.0, which doesn't fix the error but might be related, not had time to investigate yet.

@am11
Copy link
Contributor Author

am11 commented Aug 25, 2014

The seg fault thingy is fixed by 47085e5 via #399.

Now there are two tests failing on Linux and one on Windows. Its the path issue emerging from libsass. I will probably try to it figure out tomorrow or a day after.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Output path never sent to upstream?

2 participants