[pm_apply] improve mangling by patching outside the loop

[nephros]

See also #220.

This moves the sed call outside of the detection/mangle list loop.
sed command is built in the loop, but only one call to sed is made.

This saves a couple of greps and tests as well.

Tested against Test Case 2-2, from 9fb6adb#diff-bdc16c81678138d1bc10b9ac315b66564aaf85cad91efaed15e375ef837fd7a3

[Olf0]

Pretty much what I had in mind (thanks!), except for using sed "streamingly", so the old file is only read once and the new one only written once.
Plus some beautifying.

Please re-review.

[nephros]

Please re-review.

Done, Sweet.

I can't click that button to review because I am the PR author, so I'll just hit merge :)

[Olf0]

I can't click that button to review because I am the PR author,

Yes, that is idiotic logic by the GitHub coders: I also was unable to request a review from you.

so I'll just hit merge :)

Which is fine, because you surely are going to test that once more before the 3.2.1 release, right? 😉

[nephros]

Which is fine, because you surely are going to test that once more before the 3.2.1 release, right? 😉

Always.
I only have one 32bit device to test on though.

[b100dian]

On it - so I test this PRs build?
(L.E. wait, I don't find it, the CI user-interface has changed)

[b100dian]

Works on my machine (return old pulley menu) on 64 bit