Skip to content

[pm_apply] Do convert multiple libpath references #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 16, 2022
Merged

[pm_apply] Do convert multiple libpath references #225

merged 7 commits into from
Jan 16, 2022

Conversation

@Olf0
Copy link
Contributor

@Olf0 Olf0 commented Jan 4, 2022 •
edited
Loading

Re-do commit b1fea73 (as 9e16ec6) and a fixed version of commit 2a1f08b (as dd1a211) …

@Olf0
Copy link
Contributor Author

Olf0 commented Jan 4, 2022 •
edited
Loading

… i.e., manually rebase and rectify MR #222. As mentioned there:

IMO it is preferable not to squash these two three four commits, in order to keep the code changes comprehensible and traceable.

@Olf0 Olf0 requested a review from nephros January 4, 2022 01:56
@Olf0 Olf0 mentioned this pull request Jan 4, 2022
Closed
@Olf0 Olf0 marked this pull request as ready for review January 4, 2022 02:05
@Olf0 Olf0 changed the title Do convert multiple libpath references [pm_apply] Do convert multiple libpath references Jan 4, 2022
@Olf0 Olf0 mentioned this pull request Jan 4, 2022
Closed
@Olf0 Olf0 added this to the 3.2.1 milestone Jan 11, 2022
@Olf0 Olf0 self-assigned this Jan 11, 2022
@Olf0 Olf0 added debt fallout and other issues originating from the past enhancement this improves something labels Jan 11, 2022
@Olf0 Olf0 linked an issue Jan 12, 2022 that may be closed by this pull request
Optimise manglelist handling (Was: Fails if a Patch contains multiple sections matching different elements on the manglelist!) #220
Closed
nephros
nephros approved these changes Jan 15, 2022
View reviewed changes
Copy link
Contributor

@nephros nephros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got around to testing, works fine, thanks.

I have used the changes from #237 and #228 to test against the test-cases.

@Olf0 whenever you get around to it, please merge #237 either into this, or on top of it.

@Olf0 Olf0 mentioned this pull request Jan 16, 2022
Merged
@Olf0
Copy link
Contributor Author

Olf0 commented Jan 16, 2022 •
edited
Loading

@Olf0 whenever you get around to it, please merge #237 either into this, or on top of it.

Commented PR #237 and ultimately merged it.
Please review my PR #239, which enhances and supersedes your PR #238.

And I discovered another ToDo after merging #239 into this branch Olf0-patch-3:
De-indent the whole function mangle_libpath by two space characters.

@Olf0 Olf0 merged commit e80cfa5 into master Jan 16, 2022
@Olf0 Olf0 deleted the Olf0-patch-3 branch January 16, 2022 19:43
@Olf0 Olf0 mentioned this pull request Feb 15, 2022
Closed
@Olf0
Copy link
Contributor Author

Olf0 commented Feb 15, 2022

See also subsequent PRs #241 and #242.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nephros nephros nephros approved these changes

Assignees

@Olf0 Olf0

Labels

debt fallout and other issues originating from the past enhancement this improves something

Projects

None yet

Milestone

3.2.1

Development

Successfully merging this pull request may close these issues.

Optimise manglelist handling (Was: Fails if a Patch contains multiple sections matching different elements on the manglelist!)

3 participants

@Olf0 @nephros