Skip to content

[pm_unapply] Enhance checks&balances and debug output #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2022
Merged

[pm_unapply] Enhance checks&balances and debug output #228

merged 2 commits into from
Jan 16, 2022

Conversation

@Olf0
Copy link
Contributor

@Olf0 Olf0 commented Jan 12, 2022

if [ -f "$PATCH_FILE" ] and later if [ ! -f "$PATCH_FILE" ] was a bit mindless.

@Olf0
[pm_unapply] Enhance checks&balances and debug output
0d1be3c 
`if [ -f "$PATCH_FILE" ]` and later `if [ ! -f "$PATCH_FILE" ]` was a bit mindless.
@Olf0 Olf0 requested a review from nephros January 12, 2022 01:53
@Olf0 Olf0 added enhancement this improves something patching related to activating, deactivating and handling Patches trivial UX design and behaviour of UI components labels Jan 12, 2022
@Olf0 Olf0 self-assigned this Jan 12, 2022
@Olf0 Olf0 added this to the 3.2.1 milestone Jan 12, 2022
Olf0 added a commit that referenced this pull request Jan 12, 2022
@Olf0
[pm_apply] Enhance checks&balances and debug output
f6af3d4 
Counterpart of MR #228
@Olf0 Olf0 mentioned this pull request Jan 15, 2022
Closed
@Olf0
Copy link
Contributor Author

Olf0 commented Jan 16, 2022 •
edited
Loading

@nephros, please do not forget to approve this one over all the (constructive) fuzz about #225++: It is just a subset of it applied to pm_unapply.
And you already seem to have used this PR #228: "I have used the changes from #237 and #228 to test against the test-cases."

@Olf0 Olf0 merged commit 1d4ab44 into master Jan 16, 2022
@Olf0 Olf0 deleted the Olf0-patch-1 branch January 16, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nephros nephros nephros approved these changes

Assignees

@Olf0 Olf0

Labels

enhancement this improves something patching related to activating, deactivating and handling Patches trivial UX design and behaviour of UI components

Projects

None yet

Milestone

3.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Olf0 @nephros