-
-
Notifications
You must be signed in to change notification settings - Fork 697
Add internet doctest marker to various places using gap group atlas #41183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Some distributions (at least Arch and Gentoo) include the atlasrep data with their gap packages and don't need internet access - this will unnecessarily skip these tests there unless they are run with A better fix would be to add a feature test for the availability of the atlasrep data, and use it in the relevant tests. |
|
|
My idea is not to check for the files presence (which, as you said, can be in multiple places, even downloaded by gap itself in a previous run), but rather run one of these gap computations that need the data in the feature test, with a reasonable timeout (say 5s), and disable the feature if it times out. |
8a01b97 to
151b9be
Compare
|
note on the failure at the later step: it's triggered by the (mere) import of |
|
server is back up. @antonio-rojas do you know how Arch inject the data to the package? As a (slightly more reliable) workaround we may do that on the CI first. |
Unfortunately GAP will still try to contact the network by default (and hang if the website is down) even if the data is installed, so one needs to disable that option, see https://github.com/gentoo/gentoo/blob/master/dev-gap/atlasrep/files/atlasrep-2.1.7-no-remote-access.patch |
|
Since the server is OK now, we do not need this in CI |
Temporary fix for #39244
📝 Checklist
⌛ Dependencies