Skip to content

polynomials/fix category #38767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 12, 2024
Merged

polynomials/fix category #38767

merged 10 commits into from
Oct 12, 2024

Conversation

@mantepse
Copy link
Contributor

@mantepse mantepse commented Oct 4, 2024 •
edited
Loading

We put polynomials (and friends) into the category of algebras with basis.

Dependencies: #38729

@github-actions
Copy link

github-actions bot commented Oct 4, 2024

Documentation preview for this PR (built with commit 6a5aece; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tscrim
Copy link
Collaborator

tscrim commented Oct 4, 2024

@nbruin @fchapoton @xcaruso cc-ing you in case you have some thoughts/comments about doing this.

tscrim
tscrim approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no comments, then positive review. (Something I've wanted to do for awhile, thank you!)

@vbraun vbraun merged commit 67e1892 into sagemath:develop Oct 12, 2024
23 checks passed
@mantepse mantepse deleted the polynomials/fix_category branch October 13, 2024 08:42
@xcaruso
Copy link
Contributor

xcaruso commented Oct 17, 2024 •
edited
Loading

Thanks @tscrim for pointing this to me and sorry for not being reactive.
I actually do not have a strong opinion on this and I'm definitely happy with your positive review.

However, I should say that I'm quite confused with the dichotomy between the classes FreeModule and CombinatorialFreeModule. I think I understand that they support different kind of features: basically the former is more oriented towards linear algebra in finite dimension, while the former allows for infinite dimensional spaces, more abstract constructions (as tensor products, etc.) and custom names for elements in a basis. But, IMO, it's really a shame because we cannot having both at the same time.

Concretely, recently, I implemented Ore modules (see #38703) and was embarrassed by this. I finally chose to derive from FreeModule because I was interested in having submodules and quotients, two constructions which are more common in the class FreeModule. However, I was not entirely convinced.

Any thoughts about this? (Please answer in #38703 - and review this PR at the same time :-))

@mantepse mantepse mentioned this pull request Oct 17, 2024
Merged
5 tasks
@mezzarobba mezzarobba mentioned this pull request Nov 26, 2024
Closed
2 tasks
@mantepse mantepse mentioned this pull request Nov 27, 2024
Merged
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 8, 2024
b5d7b78 
sagemathgh-39044: provide default argument for monomial_coefficients
    
This is a followup to sagemath#38767, where we put polynomials into the category
of modules with basis.  Back then, we missed the fact that
`monomial_coefficients` should take an optional argument `copy`, which
we fix here.

Fixes sagemath#39037
    
URL: sagemath#39044
Reported by: Martin Rubey
Reviewer(s): Marc Mezzarobba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tscrim tscrim tscrim approved these changes

Assignees

No one assigned

Labels

c: categories c: commutative algebra t: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mantepse @tscrim @xcaruso @vbraun