Further libffi fixes

[jdemeyer]

with #27219 done, all it remains is just to fix spkg-configure.m4

Depends on #27109
Depends on #27219

CC: @embray @strogdon

Component: packages: standard

Author: Erik Bray

Branch: 07e5561

Reviewer: Erik Bray, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/27114

[jdemeyer]

Branch: u/embray/build/ticket-27109

[jdemeyer]

Commit: 4d9ccb4

[jdemeyer]

New commits:

bfa7c90	Trac #27109: Include upstream patch to libffi for --disable-multi-os-directory
4d9ccb4	Trac #27109: Use pkg-config if possible to detect libffi

[jdemeyer]

Dependencies: #27109

[embray]

comment:4

Since Steven already said this worked, I'm inclined to go ahead and set this to positive review. Though I might like to try on OSX since it doesn't have pkg-config and I'm not 100% sure what it will do in this case (I think it will "fail correctly" but I'm not certain).

[strogdon]

comment:5

Replying to @embray:

Since Steven already said this worked, I'm inclined to go ahead and set this to positive review. Though I might like to try on OSX since it doesn't have pkg-config and I'm not 100% sure what it will do in this case (I think it will "fail correctly" but I'm not certain).

I'm fine with this. I too think it should be checked on other distros.

[strogdon]

comment:6

Perhaps we should try to get this in as soon as possible, else there will be Linuxes with system libffi installed where the Sage version will be built and used. A system libffi will then not be used until an upgrade or a manual removal of the Sage installed version.

[tscrim]

comment:7

See https://groups.google.com/forum/?pli=1#!topic/sage-devel/PvcY2LHU1fo

[strogdon]

comment:8

Is there any reason why the patchbot emmits:

configure:8323: error: possibly undefined macro: AC_SEARCH_LIBS
configure:8324: error: possibly undefined macro: AC_CHECK_HEADERS

Shouldn't it have autotools installed?

[embray]

comment:9

On OSX this "works" okay, or doesn't work as the case may be, in that it (correctly) fails to find pkg-config, and thus does not try to use pkg-config.

I am seeing some other troubling problems failing to detect a system libffi on OSX, but I think whatever that problem is predates this ticket.