libffi tries to install to ${prefix}/lib64 on some Linuxes

[embray]

The problem is it unconditionally appends the output of GCC's -print-multi-os-directory flag to the install location, whereas when installing in $SAGE_LOCAL we just always want $SAGE_LOCAL/lib.

This is already fixed upstream, so we just need to include that patch.

CC: @strogdon @fchapoton @jdemeyer

Component: packages: standard

Author: Erik Bray

Branch/Commit: bfa7c90

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/27109

[embray]

comment:1

Just in case you have anything to add.

[jdemeyer]

Replying to @embray:

I'm actually not sure why we're using such an old version. Maybe just because it's the version that used to be vendored with CPython.

No, it's because there hasn't been a release of libffi since 2014! There is a "libffi 3.3 Release Candidate 0" though: https://github.com/libffi/libffi/releases

[jdemeyer]

comment:3

I'm not sure how to proceed here... using that 3.3rc0 in Sage doesn't sound right, so maybe just try to find a simple work-around in the build script?

[jdemeyer]

Author: Jeroen Demeyer

[jdemeyer]

Branch: u/jdemeyer/libffi_tries_to_install_to___prefix__lib64_on_some_linuxes

[sagetrac-git]

Commit: 56eea27

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

56eea27

Add patch to set toolexeclibdir=libdir

[jdemeyer]

comment:7

A very simple (but admittedly ugly) fix.

[strogdon]

comment:8

Replying to @jdemeyer:

A very simple (but admittedly ugly) fix.

Is there potentially something else that is at issue? Sage tries to build libffi on my Gentoo box where it fails. I have had libffi-3.2.1 installed on the Gentoo box for over a year. I do not really need to install libffi under Sage. So something did not find my installed libffi and tries to install it under Sage. Is a ./configure necessary? Shouldn't it have been run when typing make?

[embray]

comment:9

Replying to @jdemeyer:

I'm not sure how to proceed here... using that 3.3rc0 in Sage doesn't sound right, so maybe just try to find a simple work-around in the build script?

I was just going to add the patch from upstream (and update spkg-install to configure with --disable-multi-os-directory. I was going to do it earlier but I had something else come up.