Add new cargo stable benchmark
#2173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2025
nnethercote
reviewed
Jul 2, 2025
nnethercote
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new stable benchmark based on Cargo from circa Rust ~1.24.0. I was able to get this benchmark compiled with almost all versions of Rust from 1.26.0 (when we started benchmarking) all the way to today (with the exception of some unstable fingerprints, but these plague more benchmarks), although I need an old 1.0.0 OpenSLL version patched on the benchmarking machine. After we finish the stable benchmark backfill on the new machine, I will update the lockfile, so that it supports a new OpenSSL.
This should be an alternative to
style-servo, which I intend to remove, because it has an unpinned git dependency and I couldn't get it to compile with old Rust versions anymore.Related issue: #2169