Closed
Description
We have a new benchmarking machine available, which we would like to use instead of the old collector. This is orthogonal to the current Project Goal where we implement support for multiple collector machines.
Current plan:
- Configure new machine
- Provision new
rustc-perf
server simpleinfra#736 - Add configuration for the rustc-perf collector machine simpleinfra#738
- add rustc-perf-one to bastion allow list simpleinfra#742
- Disable swap on rustc-perf simpleinfra#743
- Install AWS CLI on the rustc-perf collector machines simpleinfra#744
- Replace AWS CLI v2 with v1 on rustc-perf simpleinfra#745
- Provision new
- Wait for 1.88 stable artifacts to be benchmarked by the old machine
- Temporarily disable benchmarking of stable artifacts (Temporarily disable release artifact benchmarking #2172)
- Stop collection on the old machine (don't forget to actually disable the benchmarking service, not just stop it)
- Delete last ~2 days of benchmark results, to let the new machine re-benchmark it
- Start collection on the new machine
- Let it catch up, watch for any potential issues
- If everything is ok, run custom script for backfilling stable benchmark results on the new machine (including new stable cargo benchmark, which replaces style-servo)
- Handle switchover of stable results by renaming the old stable artifacts in the DB
- Upstream the cargo stable benchmark and remove style-servo
- Re-enable benchmarking of stable artifacts (Make
cargo
compilable with modern rustc and re-enable stable benchmarks #2179)
The move to the new machine was documented here.
Executed the following SQL scripts to handle switchover of stable results:
UPDATE artifact
SET name = CONCAT('ax41-', name)
WHERE type = 'release' AND name NOT LIKE '%-ax42';
To give prefix to old artifacts (the dashboard only loads release artifacts starting with "1." or "beta-"
And then
UPDATE artifact
SET name = SUBSTRING(name, 1, LENGTH(name) - 5)
WHERE type = 'release' AND name LIKE '%-ax42';
The first master PR benchmarked by the new machine was rust-lang/rust#141875 (commit rust-lang/rust@6988a8f).
Metadata
Metadata
Assignees
Labels
No labels