Skip to content

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Aug 7, 2020

  • Add docstring to Parser field
  • Remove unnecessary unwrap
  • Remove unnecessary borrow
  • Fix indentation of some teachtext output

* Add docstring to `Parser` field
* Remove unnecessary `unwrap`
* Remove unnecessary borrow
* Fix indentation of some `teach`text output
@rust-highfive
Copy link
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2020
@Dylan-DPC-zz
Copy link

looks fine to me

r? @Dylan-DPC

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 8, 2020

📌 Commit 7e9a848 has been approved by Dylan-DPC

@rust-highfive rust-highfive assigned Dylan-DPC-zz and unassigned varkor Aug 8, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 8, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#75224 (Don't call a function in function-arguments-naked.rs)
 - rust-lang#75237 (Display elided lifetime for non-reference type in doc)
 - rust-lang#75250 (make MaybeUninit::as_(mut_)ptr const)
 - rust-lang#75253 (clean up const-hacks in int endianess conversion functions)
 - rust-lang#75259 (Add missing backtick)
 - rust-lang#75267 (Small cleanup)
 - rust-lang#75270 (fix a couple of clippy findings)

Failed merges:

r? @ghost
@bors bors merged commit 81546de into rust-lang:master Aug 8, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants