Don't call a function in function-arguments-naked.rs #75224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-lang#75096 It's U.B. to use anything other than inline assmebling in a naked function. Fortunately, the `#break` directive works fine without anything in the function body.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @Amanieu |
|
It is also UB to not have anything in a naked function. You need an |
We need to use inline assembly, which is inherently platform-specific.
|
@Amanieu: I've added a |
Amanieu
reviewed
Aug 7, 2020
Co-authored-by: Amanieu d'Antras <[email protected]>
|
@bors r+ rollup |
|
📌 Commit c34c77c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 8, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#75224 (Don't call a function in function-arguments-naked.rs) - rust-lang#75237 (Display elided lifetime for non-reference type in doc) - rust-lang#75250 (make MaybeUninit::as_(mut_)ptr const) - rust-lang#75253 (clean up const-hacks in int endianess conversion functions) - rust-lang#75259 (Add missing backtick) - rust-lang#75267 (Small cleanup) - rust-lang#75270 (fix a couple of clippy findings) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75096
It's U.B. to use anything other than inline assmebling in a naked
function. Fortunately, the
#breakdirective works fine withoutanything in the function body.