Skip to content

Regression test for undefined __chkstk on aarch64-unknown-uefi #148437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

Regression test for undefined __chkstk on aarch64-unknown-uefi #148437

merged 1 commit into from
Nov 4, 2025
+17 −0

Conversation

@Jamesbarford
Copy link
Contributor

@Jamesbarford Jamesbarford commented Nov 3, 2025

Adds a test for compiling a block of code with target aarch64-unknown-uefi.

Closes #98254

@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jieyouxu
Copy link
Member

jieyouxu commented Nov 3, 2025

Huh, does this test actually run in CI? Since aarch64-unknown-uefi is a Tier 2 target, right?

@jieyouxu
Copy link
Member

jieyouxu commented Nov 3, 2025

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@davidtwco
Copy link
Member

davidtwco commented Nov 3, 2025 •
edited
Loading

Basically, I can't accept a test that never runs in rust-lang/rust CI.

Why? I appreciate that it isn't especially useful if it isn't being tested, but it is still useful for people who work on these targets locally to have tests in tree, and even if it gets forgotten and years later we discover it never passes, it's still a useful indication of intent. (If this is a standard policy we have that I'm unaware of, do let me know)

@jieyouxu
Copy link
Member

jieyouxu commented Nov 3, 2025

Basically, I can't accept a test that never runs in rust-lang/rust CI.

Why? I appreciate that it isn't especially useful if it isn't being tested, but it is still useful for people who work on these targets locally to have tests in tree, and even if it gets forgotten and years later we discover it never passes, it's still a useful indication of intent. (If this is a standard policy we have that I'm unaware of, do let me know)

Good question, I'm not sure why I thought that initially, considering this is intended as a target test. I guess I was initially thinking of the //@ ignore-tests and the tests that we never run in r-l/r which gave false sense of confidence to our coverage, but this is clearly not the case for a target-specific test.

@jieyouxu
Copy link
Member

jieyouxu commented Nov 3, 2025

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 3, 2025
jieyouxu
jieyouxu reviewed Nov 3, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits

View changes since this review

@jieyouxu
Copy link
Member

jieyouxu commented Nov 3, 2025

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2025
jieyouxu
jieyouxu approved these changes Nov 3, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, waiting for basic CI on directives.

View changes since this review

@jieyouxu jieyouxu changed the title test for aarch64-unknown-uefi Regression test for undefined __chkstk on aarch64-unknown-uefi Nov 3, 2025
@jieyouxu jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 3, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Nov 4, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 4, 2025

📌 Commit 1bc898e has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 4, 2025
@Zalathar
Rollup merge of rust-lang#148437 - Jamesbarford:test/issue-98254, r=j…
eeafaff 
…ieyouxu

Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`

Adds a test for compiling a block of code with target `aarch64-unknown-uefi`.

Closes rust-lang#98254
@Zalathar Zalathar mentioned this pull request Nov 4, 2025
Closed
bors added a commit that referenced this pull request Nov 4, 2025
@bors
Auto merge of #148458 - Zalathar:rollup-2xmquy0, r=Zalathar
11e10a4 
Rollup of 10 pull requests

Successful merges:

 - #133149 (Provide more context on `Fn` closure modifying binding)
 - #143037 (Make named asm_labels lint not trigger on hexagon register spans)
 - #144529 (Add `#[rustc_pass_indirectly_in_non_rustic_abis]`)
 - #145915 (Stabilize `fmt::from_fn`)
 - #145974 (Stabilize -Zno-jump-tables into -Cjump-tables=bool)
 - #146057 (feat: add `from_fn_ptr` to `Waker` and `LocalWaker`)
 - #146301 (library: std: sys: net: uefi: tcp: Implement write_vectored)
 - #148437 (Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`)
 - #148448 (Update books)
 - #148451 (tidy: Fix false positives with absolute repo paths in `pal.rs` `check()`)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 4, 2025
@Zalathar
Rollup merge of rust-lang#148437 - Jamesbarford:test/issue-98254, r=j…
c0b88ad 
…ieyouxu

Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`

Adds a test for compiling a block of code with target `aarch64-unknown-uefi`.

Closes rust-lang#98254
@Zalathar Zalathar mentioned this pull request Nov 4, 2025
Closed
bors added a commit that referenced this pull request Nov 4, 2025
@bors
Auto merge of #148460 - Zalathar:rollup-kihb2hz, r=Zalathar
3b24bf2 
Rollup of 9 pull requests

Successful merges:

 - #133149 (Provide more context on `Fn` closure modifying binding)
 - #144529 (Add `#[rustc_pass_indirectly_in_non_rustic_abis]`)
 - #145915 (Stabilize `fmt::from_fn`)
 - #145974 (Stabilize -Zno-jump-tables into -Cjump-tables=bool)
 - #146057 (feat: add `from_fn_ptr` to `Waker` and `LocalWaker`)
 - #146301 (library: std: sys: net: uefi: tcp: Implement write_vectored)
 - #148437 (Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`)
 - #148448 (Update books)
 - #148451 (tidy: Fix false positives with absolute repo paths in `pal.rs` `check()`)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar Zalathar mentioned this pull request Nov 4, 2025
Merged
bors added a commit that referenced this pull request Nov 4, 2025
@bors
Auto merge of #148462 - Zalathar:rollup-6gckwu6, r=Zalathar
90b6588 
Rollup of 8 pull requests

Successful merges:

 - #133149 (Provide more context on `Fn` closure modifying binding)
 - #145915 (Stabilize `fmt::from_fn`)
 - #145974 (Stabilize -Zno-jump-tables into -Cjump-tables=bool)
 - #146057 (feat: add `from_fn_ptr` to `Waker` and `LocalWaker`)
 - #146301 (library: std: sys: net: uefi: tcp: Implement write_vectored)
 - #148437 (Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`)
 - #148448 (Update books)
 - #148451 (tidy: Fix false positives with absolute repo paths in `pal.rs` `check()`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f41c2e0 into rust-lang:master Nov 4, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 4, 2025
rust-timer added a commit that referenced this pull request Nov 4, 2025
@rust-timer
Unrolled build for #148437
7484d4d 
Rollup merge of #148437 - Jamesbarford:test/issue-98254, r=jieyouxu

Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`

Adds a test for compiling a block of code with target `aarch64-unknown-uefi`.

Closes #98254
@Jamesbarford Jamesbarford deleted the test/issue-98254 branch November 4, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

error: undefined symbol: __chkstk on aarch64-unknown-uefi

5 participants

@Jamesbarford @rustbot @jieyouxu @davidtwco @bors