Skip to content

feat: add from_fn_ptr to Waker and LocalWaker #146057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2025
Merged

feat: add from_fn_ptr to Waker and LocalWaker #146057

merged 2 commits into from
Nov 4, 2025

Conversation

@Ddystopia
Copy link
Contributor

@Ddystopia Ddystopia commented Aug 31, 2025 •
edited
Loading

Closes: #146055

@rustbot
Copy link
Collaborator

rustbot commented Aug 31, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 31, 2025
@xizheyin
Copy link
Member

xizheyin commented Aug 31, 2025

Thanks for the PR. Using Closes #146055 in the PR description can close the issue when this PR is merged.

@jieyouxu
Copy link
Member

jieyouxu commented Sep 1, 2025

This may need an API Change Proposal instead of a r-l/r issue.
r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 1, 2025
@rustbot rustbot assigned dtolnay and unassigned scottmcm Sep 1, 2025
@Ddystopia Ddystopia mentioned this pull request Sep 1, 2025
Open
@cyrgani cyrgani added the S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. label Sep 1, 2025
@dtolnay dtolnay mentioned this pull request Nov 4, 2025
Open
3 tasks
@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2025

⚠️ Warning ⚠️

dtolnay
dtolnay approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

View changes since this review

@dtolnay
Copy link
Member

dtolnay commented Nov 4, 2025

I changed the tracking issue to #148457.

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 4, 2025

📌 Commit 75835fb has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 4, 2025
@Zalathar
Rollup merge of rust-lang#146057 - Ddystopia:waker-fn, r=dtolnay
a21b45c 
feat: add `from_fn_ptr` to `Waker` and `LocalWaker`

Closes: rust-lang#146055
@Zalathar Zalathar mentioned this pull request Nov 4, 2025
Closed
bors added a commit that referenced this pull request Nov 4, 2025
@bors
Auto merge of #148458 - Zalathar:rollup-2xmquy0, r=Zalathar
11e10a4 
Rollup of 10 pull requests

Successful merges:

 - #133149 (Provide more context on `Fn` closure modifying binding)
 - #143037 (Make named asm_labels lint not trigger on hexagon register spans)
 - #144529 (Add `#[rustc_pass_indirectly_in_non_rustic_abis]`)
 - #145915 (Stabilize `fmt::from_fn`)
 - #145974 (Stabilize -Zno-jump-tables into -Cjump-tables=bool)
 - #146057 (feat: add `from_fn_ptr` to `Waker` and `LocalWaker`)
 - #146301 (library: std: sys: net: uefi: tcp: Implement write_vectored)
 - #148437 (Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`)
 - #148448 (Update books)
 - #148451 (tidy: Fix false positives with absolute repo paths in `pal.rs` `check()`)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 4, 2025
@Zalathar
Rollup merge of rust-lang#146057 - Ddystopia:waker-fn, r=dtolnay
bf722ca 
feat: add `from_fn_ptr` to `Waker` and `LocalWaker`

Closes: rust-lang#146055
@Zalathar Zalathar mentioned this pull request Nov 4, 2025
Closed
bors added a commit that referenced this pull request Nov 4, 2025
@bors
Auto merge of #148460 - Zalathar:rollup-kihb2hz, r=Zalathar
3b24bf2 
Rollup of 9 pull requests

Successful merges:

 - #133149 (Provide more context on `Fn` closure modifying binding)
 - #144529 (Add `#[rustc_pass_indirectly_in_non_rustic_abis]`)
 - #145915 (Stabilize `fmt::from_fn`)
 - #145974 (Stabilize -Zno-jump-tables into -Cjump-tables=bool)
 - #146057 (feat: add `from_fn_ptr` to `Waker` and `LocalWaker`)
 - #146301 (library: std: sys: net: uefi: tcp: Implement write_vectored)
 - #148437 (Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`)
 - #148448 (Update books)
 - #148451 (tidy: Fix false positives with absolute repo paths in `pal.rs` `check()`)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar Zalathar mentioned this pull request Nov 4, 2025
Merged
bors added a commit that referenced this pull request Nov 4, 2025
@bors
Auto merge of #148462 - Zalathar:rollup-6gckwu6, r=Zalathar
90b6588 
Rollup of 8 pull requests

Successful merges:

 - #133149 (Provide more context on `Fn` closure modifying binding)
 - #145915 (Stabilize `fmt::from_fn`)
 - #145974 (Stabilize -Zno-jump-tables into -Cjump-tables=bool)
 - #146057 (feat: add `from_fn_ptr` to `Waker` and `LocalWaker`)
 - #146301 (library: std: sys: net: uefi: tcp: Implement write_vectored)
 - #148437 (Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`)
 - #148448 (Update books)
 - #148451 (tidy: Fix false positives with absolute repo paths in `pal.rs` `check()`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 149eb1a into rust-lang:master Nov 4, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 4, 2025
rust-timer added a commit that referenced this pull request Nov 4, 2025
@rust-timer
Unrolled build for #146057
802e17e 
Rollup merge of #146057 - Ddystopia:waker-fn, r=dtolnay

feat: add `from_fn_ptr` to `Waker` and `LocalWaker`

Closes: #146055
@bors
Copy link
Collaborator

bors commented Nov 4, 2025

⌛ Testing commit 75835fb with merge 90b6588...

@Kobzol
Copy link
Member

Kobzol commented Nov 4, 2025

@bors r-

Already merged.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels

S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Waker::from_fn_ptr

9 participants

@Ddystopia @rustbot @xizheyin @jieyouxu @dtolnay @bors @Kobzol @scottmcm @cyrgani