Rollup of 10 pull requests #148356

matthiaskrgr · 2025-11-01T07:25:49Z

Successful merges:

Tweak output of missing lifetime on associated type #135602 (Tweak output of missing lifetime on associated type)
Implement pin-project in pattern matching for &pin mut|const T #139751 (Implement pin-project in pattern matching for &pin mut|const T)
Update bundled musl to 1.2.5 #142682 (Update bundled musl to 1.2.5)
Simplify code to generate line numbers in highlight #148171 (Simplify code to generate line numbers in highlight)
Unpin libc and rustix in compiler and rustbook #148263 (Unpin libc and rustix in compiler and rustbook)
[rustdoc search] Include extern crates when filtering on import #148301 ([rustdoc search] Include extern crates when filtering on import)
Don't require dlltool with the dummy backend on MinGW #148330 (Don't require dlltool with the dummy backend on MinGW)
cleanup: upstream dropped amx-transpose functionality #148338 (cleanup: upstream dropped amx-transpose functionality)
Clippy subtree update #148340 (Clippy subtree update)
nonpoison::Condvar should take MutexGuard by reference #148343 (nonpoison::Condvar should take MutexGuard by reference)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

…renced by name, but not called.

…n module.

…token cursor.

…ttrs

…r=GuillaumeGomez Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes r? `@GuillaumeGomez`

Remove boxes from ast list elements Less indirection should be better perf.

When matched against `Result` with copyable `Ok` variant, uncopyable scrutinee won't actually be moved. But `manual_unwrap_or`/`manual_unwrap_or_default` will force it to move, which can cause problem if scrutinee is used later. changelog: [`manual_unwrap_or`]: don't lint if not safe to move scrutinee changelog: [`manual_unwrap_or_default`]: don't lint if not safe to move scrutinee Signed-off-by: Zihan <[email protected]>

…ubtree-update

Update to direct link to the Code of Conduct changelog: none

The errors were unrelated to the lint...

- make them `verbose` -- the ones spanning multiple lines were especially egregious - give a more descriptive help message

…estions" This reverts commit 25881bf.

matthiaskrgr · 2025-11-01T07:26:02Z

@bors r+ rollup=never p=5

bors · 2025-11-01T07:26:05Z

📌 Commit 0ed8002 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-11-01T10:43:23Z

⌛ Testing commit 0ed8002 with merge 1fc79f3...

Rollup of 10 pull requests Successful merges: - #135602 (Tweak output of missing lifetime on associated type) - #139751 (Implement pin-project in pattern matching for `&pin mut|const T`) - #142682 (Update bundled musl to 1.2.5) - #148171 (Simplify code to generate line numbers in highlight) - #148263 (Unpin `libc` and `rustix` in `compiler` and `rustbook`) - #148301 ([rustdoc search] Include extern crates when filtering on `import`) - #148330 (Don't require dlltool with the dummy backend on MinGW) - #148338 (cleanup: upstream dropped amx-transpose functionality) - #148340 (Clippy subtree update) - #148343 (`nonpoison::Condvar` should take `MutexGuard` by reference) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-11-01T16:43:23Z

💥 Test timed out

matthiaskrgr · 2025-11-01T16:43:34Z

@bors retry musl timeout

bors · 2025-11-01T16:44:45Z

⌛ Testing commit 0ed8002 with merge fca2e94...

bors · 2025-11-01T20:09:11Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing fca2e94 to master...

github-actions · 2025-11-01T20:12:22Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d85276b (parent) -> fca2e94 (this PR)

Test differences

Show 222 test diffs

Stage 0

errors::verify_hir_typeck_project_on_non_pin_project_type_35: [missing] -> pass (J0)

Stage 1

[rustdoc-js] tests/rustdoc-js/import-filter.rs: [missing] -> pass (J0)
[ui] tests/ui/lifetimes/missing-lifetime-in-assoc-type-1.rs: [missing] -> pass (J0)
[ui] tests/ui/lifetimes/missing-lifetime-in-assoc-type-2.rs: [missing] -> pass (J0)
[ui] tests/ui/lifetimes/missing-lifetime-in-assoc-type-3.rs: [missing] -> pass (J0)
[ui] tests/ui/lifetimes/missing-lifetime-in-assoc-type-4.rs: [missing] -> pass (J0)
[ui] tests/ui/lifetimes/missing-lifetime-in-assoc-type-5.rs: [missing] -> pass (J0)
[ui] tests/ui/pin-ergonomics/pattern-matching-deref-pattern.rs#normal: [missing] -> pass (J0)
[ui] tests/ui/pin-ergonomics/pattern-matching-deref-pattern.rs#pin_ergonomics: [missing] -> pass (J0)
[ui] tests/ui/pin-ergonomics/pattern-matching-mix-deref-pattern.rs#both: [missing] -> pass (J0)
[ui] tests/ui/pin-ergonomics/pattern-matching-mix-deref-pattern.rs#deref_patterns: [missing] -> pass (J0)
[ui] tests/ui/pin-ergonomics/pattern-matching-mix-deref-pattern.rs#normal: [missing] -> pass (J0)
[ui] tests/ui/pin-ergonomics/pattern-matching-mix-deref-pattern.rs#pin_ergonomics: [missing] -> pass (J0)
[ui] tests/ui/pin-ergonomics/pattern-matching.rs#normal: [missing] -> pass (J0)
[ui] tests/ui/pin-ergonomics/pattern-matching.rs#pin_ergonomics: [missing] -> pass (J0)
[ui] tests/ui/pin-ergonomics/pin_v2-attr.rs: [missing] -> pass (J0)
condvar::test_arc_condvar_poison: [missing] -> pass (J3)
mutex::test_arc_condvar_poison: pass -> [missing] (J3)
errors::verify_hir_typeck_project_on_non_pin_project_type_35: [missing] -> pass (J5)

Stage 2

[ui] tests/ui/lifetimes/missing-lifetime-in-assoc-type-1.rs: [missing] -> pass (J1)
[ui] tests/ui/lifetimes/missing-lifetime-in-assoc-type-2.rs: [missing] -> pass (J1)
[ui] tests/ui/lifetimes/missing-lifetime-in-assoc-type-3.rs: [missing] -> pass (J1)
[ui] tests/ui/lifetimes/missing-lifetime-in-assoc-type-4.rs: [missing] -> pass (J1)
[ui] tests/ui/lifetimes/missing-lifetime-in-assoc-type-5.rs: [missing] -> pass (J1)
[ui] tests/ui/pin-ergonomics/pattern-matching-deref-pattern.rs#normal: [missing] -> pass (J1)
[ui] tests/ui/pin-ergonomics/pattern-matching-deref-pattern.rs#pin_ergonomics: [missing] -> pass (J1)
[ui] tests/ui/pin-ergonomics/pattern-matching-mix-deref-pattern.rs#both: [missing] -> pass (J1)
[ui] tests/ui/pin-ergonomics/pattern-matching-mix-deref-pattern.rs#deref_patterns: [missing] -> pass (J1)
[ui] tests/ui/pin-ergonomics/pattern-matching-mix-deref-pattern.rs#normal: [missing] -> pass (J1)
[ui] tests/ui/pin-ergonomics/pattern-matching-mix-deref-pattern.rs#pin_ergonomics: [missing] -> pass (J1)
[ui] tests/ui/pin-ergonomics/pattern-matching.rs#normal: [missing] -> pass (J1)
[ui] tests/ui/pin-ergonomics/pattern-matching.rs#pin_ergonomics: [missing] -> pass (J1)
[ui] tests/ui/pin-ergonomics/pin_v2-attr.rs: [missing] -> pass (J1)
condvar::test_arc_condvar_poison: [missing] -> pass (J2)
mutex::test_arc_condvar_poison: pass -> [missing] (J2)
[rustdoc-js] tests/rustdoc-js/import-filter.rs: [missing] -> pass (J4)

Additionally, 186 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard fca2e941f86f51cd3c3254518f45e2145563f6be --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

pr-check-1: 1909.8s -> 1458.6s (-23.6%)
x86_64-gnu-stable: 7619.3s -> 6528.5s (-14.3%)
dist-riscv64-linux: 4901.1s -> 5540.6s (+13.0%)
dist-various-1: 4153.1s -> 3640.7s (-12.3%)
test-various: 6846.9s -> 6050.3s (-11.6%)
i686-gnu-nopt-1: 8139.3s -> 7274.2s (-10.6%)
i686-gnu-1: 8281.0s -> 7482.8s (-9.6%)
x86_64-gnu-gcc: 3382.3s -> 3060.1s (-9.5%)
dist-arm-linux-musl: 5570.7s -> 6082.2s (+9.2%)
dist-ohos-x86_64: 4271.8s -> 4640.4s (+8.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-01T20:12:38Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#135602	Tweak output of missing lifetime on associated type	`06d32fcb347ee93b1d88008c761c912949ddf2fa` (link)
#139751	Implement pin-project in pattern matching for `&pin mut\|con…	`18c32d09afbd2cfb5310e1d238ba0bc2ff03dfa0` (link)
#142682	Update bundled musl to 1.2.5	`737d0ebdcadfc32f0d4e0b655f9c85b2a6165029` (link)
#147676	Return spans out of `is_doc_comment` to reduce reliance on …	❌ conflicts merging '5f0f7d8543' into previous master ❌
#147713	Retire ast::TyAliasWhereClauses.	❌ conflicts merging '26b12a9756' into previous master ❌
#148171	Simplify code to generate line numbers in highlight	`10997e99600c9caba60e55d7dfc3ef39481fe8b3` (link)
#148263	Unpin `libc` and `rustix` in `compiler` and `rustbook`	`57abcbb5399290e428b914235959ef76c21e5aa5` (link)
#148301	[rustdoc search] Include extern crates when filtering on `i…	`ca17abf58cc31626d5fa2e30091d3406e461c1d0` (link)
#148330	Don't require dlltool with the dummy backend on MinGW	`a5f05a72c2451bff4d637da539bdd0a7a6334155` (link)
#148338	cleanup: upstream dropped amx-transpose functionality	`a3549256e3da87d4e59c35185f84bef85e50fbe5` (link)
#148340	Clippy subtree update	`1a20e8cc10b5bbe42ea2dd2ea0d6c15c1129649e` (link)
#148343	`nonpoison::Condvar` should take `MutexGuard` by reference	`908ffb1a35ff0f8610b0dc3881e9ff00ad5de057` (link)

previous master: d85276b256

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-11-01T21:19:46Z

Finished benchmarking commit (fca2e94): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.0%	[-3.0%, -3.0%]	1
Improvements ✅ (secondary)	-0.4%	[-1.0%, -0.1%]	10
All ❌✅ (primary)	-3.0%	[-3.0%, -3.0%]	1

Max RSS (memory usage)

Results (primary 2.3%, secondary -1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	7.8%	[7.8%, 7.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.1%	[-3.1%, -3.1%]	1
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.3%]	2
All ❌✅ (primary)	2.3%	[-3.1%, 7.8%]	2

Cycles

Results (primary -3.4%, secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.1%, 3.3%]	3
Improvements ✅ (primary)	-3.4%	[-3.4%, -3.4%]	1
Improvements ✅ (secondary)	-2.9%	[-3.6%, -2.4%]	3
All ❌✅ (primary)	-3.4%	[-3.4%, -3.4%]	1

Binary size

Results (primary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.1%	[-1.1%, -1.1%]	1

Bootstrap: 476.797s -> 474.465s (-0.49%)
Artifact size: 390.82 MiB -> 390.82 MiB (0.00%)

Jarcho and others added 30 commits September 30, 2025 14:08

incompatible_msrv: Don't check the const version for functions refe…

c1de8ed

…renced by name, but not called.

Update bundled musl to 1.2.5

13ee69d

update all other references to musl 1.2.3 to 1.2.5

a014a9b

bump powerpc64le-unknown-linux-musl's musl to 1.2.5

52513ab

Remove boxes from ast Pat lists

d860954

pin all musl deconfigs to 1.2.5

303a828

remove references to upstreamed patches

22e6656

bump musl-cross-make commit to get fixes

b64cdd0

fmt

010b690

clippy_dev: Move parsing code to it's own module.

813eb08

clippy_dev: Validate lint name format during argument parsing.

4f403f3

clippy_dev: Rename RustSearcher to Cursor and move it to its ow…

88c0674

…n module.

clippy_dev: Use the new ranges.

5e36990

clippy_dev: Capture token patterns by position and length.

422d459

clippy_dev: Add specialized helpers for finding identifiers to the …

1b31b09

…token cursor.

clean-up tests

3e1f862

option_option: split part of diagnostic message into help message

2fe9d4b

return spans out of is_doc_comment to reduce reliance on .span() on a…

5f0f7d8

…ttrs

Add multiple-inherent-impl tests

1e1c1f3

Rollup merge of rust-lang#147676 - jdonszelmann:span-is-doc-comment, …

14b446c

…r=GuillaumeGomez Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes r? `@GuillaumeGomez`

Auto merge of rust-lang#146221 - camsteffen:ast-boxes, r=cjgillot

2c8a9e2

Remove boxes from ast list elements Less indirection should be better perf.

Merge commit 'd9fb15c4b1ebe9e7dc419e07f53af681d7860cbe' into clippy-s…

8f61305

…ubtree-update

Fix clippy for impl_trait_header changes

6a0aa12

Update link to the Code of Conduct

269679e

Update link to the Code of Conduct (rust-lang#15903)

1ecb18a

Update to direct link to the Code of Conduct changelog: none

clean-up tests

4463ba7

fix option_map_unit_fn_unfixable.rs

b0ecbdf

The errors were unrelated to the lint...

improve the suggestion

98db098

- make them `verbose` -- the ones spanning multiple lines were especially egregious - give a more descriptive help message

Revert "fix(elidable_lifetime_names): avoid overlapping spans in sugg…

c6426f5

…estions" This reverts commit 25881bf.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 1, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 1, 2025

bors merged commit fca2e94 into rust-lang:master Nov 1, 2025
12 checks passed

rustbot added this to the 1.93.0 milestone Nov 1, 2025

This was referenced Nov 1, 2025

Rework c_variadic #141980

Open

Add #[rustc_pass_indirectly_in_non_rustic_abis] #144529

Merged

Tweak output of missing lifetime on associated type #145314

Merged

Weekly cargo update #145516

Open

Add the cpuid target feature #146560

Open

bors mentioned this pull request Nov 1, 2025

add transparent attribute for mod items #147709

Open

Rollup of 10 pull requests #148356

Rollup of 10 pull requests #148356

Uh oh!

Conversation

matthiaskrgr commented Nov 1, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Nov 1, 2025

Uh oh!

bors commented Nov 1, 2025

Uh oh!

bors commented Nov 1, 2025

Uh oh!

bors commented Nov 1, 2025

Uh oh!

matthiaskrgr commented Nov 1, 2025

Uh oh!

bors commented Nov 1, 2025

Uh oh!

bors commented Nov 1, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 1, 2025

Test differences

Stage 0

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Nov 1, 2025

Uh oh!

rust-timer commented Nov 1, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

34 participants

matthiaskrgr commented Nov 1, 2025 •

edited by rustbot

Loading