add transparent attribute for mod items #147709
Conversation
|
Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
rustbot
added
A-attributes
| /// * A trait or an enum (it implicitly contains associated types, methods and variant | ||
| /// constructors). | ||
| Def(DefKind, DefId, Option<Symbol>), | ||
| Def(DefKind, DefId, Option<(Symbol, bool)>), |
There was a problem hiding this comment.
This was the most obvious place to put this but it doesn't feel great, don't love all the places where I changed shit to name_and_transparent, open to suggestions for how to better thread this information through
| transmute_opts, | ||
| transmute_trait, | ||
| transmute_unchecked, | ||
| transparent, |
There was a problem hiding this comment.
I feel like I'm probably doing this part subtly wrong.
The transparent symbol already exists and I'm using it, I tried seeing if I could stay away from it and find a way to have all the compiler internal stuff talk about it with a unique symbol (transparent_modules) but have the actual ident of the attribute be transparent but it seemed like this was controlling that. If I got that wrong lmk.
This comment has been minimized.
This comment has been minimized.
|
With that nit, r=me for just the attributes stuff. I don't know as much about the name resolution part to sign off on that but thats for petrochenkov :) |
yaahc
force-pushed
the
transparent-modules
branch
2 times, most recently
from
08b1160 to
b2651d1
Compare
This comment has been minimized.
This comment has been minimized.
yaahc
force-pushed
the
transparent-modules
branch
2 times, most recently
from
20236fb to
741a558
Compare
yaahc
force-pushed
the
transparent-modules
branch
from
741a558 to
74e1b33
Compare
| /// Allows for transmuting between arrays with sizes that contain generic consts. | ||
| (unstable, transmute_generic_consts, "1.70.0", Some(109929)), | ||
| /// Allows #[transparent] on modules to inherit lexical scopes. | ||
| (unstable, transparent_modules, "1.91.0", Some(79260)), |
|
|
||
| gated!( | ||
| transparent, Normal, | ||
| template!(Word, "https://github.com/rust-lang/rust/issues/79260#issuecomment-731773625"), |
There was a problem hiding this comment.
probably also want to update this to point to actual documentation (I don't intend to add that, if its a blocker then leave this open or close it until someone comes along who wants to push this over the finish line)
yaahc
force-pushed
the
transparent-modules
branch
from
74e1b33 to
afaa6b5
Compare
| pub(crate) use s; | ||
| } | ||
|
|
||
| trait IWantAMethod { |
There was a problem hiding this comment.
you'll also want a test in which you use #[transparent] without the feature gate to make sure it's properly rejected without the feature
There was a problem hiding this comment.
note: this does work correctly, I just tested it, but you still want to have a test for it
|
@rustbot author |
rustbot
added
S-waiting-on-author
yaahc
added
the
A-resolve
|
☔ The latest upstream changes (presumably #148356) made this pull request unmergeable. Please resolve the merge conflicts. |
6 participants
Addresses #79260
r? @petrochenkov