Skip to content

Conversation

@cuviper
Copy link
Member

@cuviper cuviper commented Oct 23, 2025

Crater for 1.91-beta found that this unstable macro caused ambiguity in the ecosystem: #147971

Since we are very close to release, it's probably best to just revert the macro for now, and re-add it later in a less invasive way -- i.e. not a top-level macro, and not in the prelude until a future edition (as noted here).

@rustbot label beta-nominated

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 23, 2025
@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@BoxyUwU
Copy link
Member

BoxyUwU commented Oct 23, 2025

lgtm but probably you want a libs reviewer

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 24, 2025

📌 Commit c01682e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2025
@bors
Copy link
Collaborator

bors commented Oct 24, 2025

⌛ Testing commit c01682e with merge 38bc246...

@bors
Copy link
Collaborator

bors commented Oct 24, 2025

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 38bc246 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 24, 2025
@bors bors merged commit 38bc246 into rust-lang:master Oct 24, 2025
12 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 24, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 27050c0 (parent) -> 38bc246 (this PR)

Test differences

Show 5 test diffs

5 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 38bc2468dea062750e767bdd5c25f8279275baa0 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu: 6821.9s -> 7666.1s (12.4%)
  2. dist-apple-various: 4000.4s -> 3617.9s (-9.6%)
  3. x86_64-msvc-ext2: 5857.0s -> 5348.5s (-8.7%)
  4. dist-arm-linux-gnueabi: 4799.8s -> 5209.5s (8.5%)
  5. dist-i686-linux: 6065.4s -> 6570.7s (8.3%)
  6. aarch64-msvc-2: 4665.1s -> 5020.3s (7.6%)
  7. dist-i586-gnu-i586-i686-musl: 5032.5s -> 5389.5s (7.1%)
  8. x86_64-msvc-ext1: 7071.0s -> 7557.9s (6.9%)
  9. dist-ohos-x86_64: 4287.9s -> 4005.9s (-6.6%)
  10. x86_64-msvc-2: 6626.6s -> 7049.2s (6.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (38bc246): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.1% [0.1%, 0.1%] 1
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.7% [-1.3%, -0.1%] 2
All ❌✅ (primary) 0.1% [0.1%, 0.1%] 1

Max RSS (memory usage)

Results (primary 0.5%, secondary 1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.8% [1.8%, 1.8%] 1
Regressions ❌
(secondary)
2.2% [1.6%, 2.8%] 2
Improvements ✅
(primary)
-0.7% [-0.7%, -0.7%] 1
Improvements ✅
(secondary)
-1.4% [-1.4%, -1.4%] 1
All ❌✅ (primary) 0.5% [-0.7%, 1.8%] 2

Cycles

Results (secondary -1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.6% [-4.7%, -2.5%] 2
All ❌✅ (primary) - - 0

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.0% [-0.0%, -0.0%] 1
All ❌✅ (primary) - - 0

Bootstrap: 474.745s -> 473.974s (-0.16%)
Artifact size: 390.51 MiB -> 390.47 MiB (-0.01%)

@cuviper
Copy link
Member Author

cuviper commented Oct 24, 2025

I hesitate to backport-approve my own PR, but time is short and it's just an unstable revert, and we did discuss this plan in the libs meeting beforehand.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 24, 2025
@cuviper cuviper mentioned this pull request Oct 24, 2025
@cuviper cuviper modified the milestones: 1.92.0, 1.91.0 Oct 24, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 24, 2025
bors added a commit that referenced this pull request Oct 25, 2025
[beta] backports

- Revert constification of `AsRef for Cow` due to inference failure #148011
- Revert constification of `Borrow` and `Deref for Cow` due to inference failure #148016
- Revert "fix: Filter suggestion parts that match existing code" #148043
- Revert "feat: implement `hash_map!` macro" #148049
- fix panic when rustc tries to reduce intermediate filenames len with utf8 #148018

r? cuviper
bors added a commit that referenced this pull request Oct 25, 2025
[beta] backports

- Revert constification of `AsRef for Cow` due to inference failure #148011
- Revert constification of `Borrow` and `Deref for Cow` due to inference failure #148016
- Revert "fix: Filter suggestion parts that match existing code" #148043
- Revert "feat: implement `hash_map!` macro" #148049
- fix panic when rustc tries to reduce intermediate filenames len with utf8 #148018

r? cuviper
tkr-sh added a commit to wini-rs/wini that referenced this pull request Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants