-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Revert "feat: implement hash_map! macro"
#148049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
352d299 to
36d04da
Compare
This comment has been minimized.
This comment has been minimized.
This reverts commit 066023e.
36d04da to
c01682e
Compare
|
|
lgtm but probably you want a libs reviewer |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 27050c0 (parent) -> 38bc246 (this PR) Test differencesShow 5 test diffs5 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 38bc2468dea062750e767bdd5c25f8279275baa0 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (38bc246): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.5%, secondary 1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -1.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 474.745s -> 473.974s (-0.16%) |
|
I hesitate to backport-approve my own PR, but time is short and it's just an unstable revert, and we did discuss this plan in the libs meeting beforehand. @rustbot label +beta-accepted |
[beta] backports - Revert constification of `AsRef for Cow` due to inference failure #148011 - Revert constification of `Borrow` and `Deref for Cow` due to inference failure #148016 - Revert "fix: Filter suggestion parts that match existing code" #148043 - Revert "feat: implement `hash_map!` macro" #148049 - fix panic when rustc tries to reduce intermediate filenames len with utf8 #148018 r? cuviper
[beta] backports - Revert constification of `AsRef for Cow` due to inference failure #148011 - Revert constification of `Borrow` and `Deref for Cow` due to inference failure #148016 - Revert "fix: Filter suggestion parts that match existing code" #148043 - Revert "feat: implement `hash_map!` macro" #148049 - fix panic when rustc tries to reduce intermediate filenames len with utf8 #148018 r? cuviper
Crater for 1.91-beta found that this unstable macro caused ambiguity in the ecosystem: #147971
Since we are very close to release, it's probably best to just revert the macro for now, and re-add it later in a less invasive way -- i.e. not a top-level macro, and not in the prelude until a future edition (as noted here).
@rustbot label beta-nominated