Skip to content

Revert constification of AsRef for Cow due to inference failure #148011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

Revert constification of AsRef for Cow due to inference failure #148011

merged 1 commit into from
Oct 23, 2025

Conversation

@clarfonthey
Copy link
Contributor

@clarfonthey clarfonthey commented Oct 23, 2025 •
edited by rustbot
Loading

Reported issue: #147964
Original PR: #145279
const AsRef tracking issue: #143773

Should have additional crater run to verify this fixes the issue.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@clarfonthey clarfonthey mentioned this pull request Oct 23, 2025
Open
@clarfonthey clarfonthey changed the title Revert inference failure from AsRef constification Revert constification of AsRef for Cow due to inference failure Oct 23, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Oct 23, 2025

r? @oli-obk

@bors r+ rollup

@rustbot rustbot assigned oli-obk and unassigned joboet Oct 23, 2025
@bors
Copy link
Collaborator

bors commented Oct 23, 2025

📌 Commit cb7fb35 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
@theemathas theemathas added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 23, 2025
@jhpratt jhpratt mentioned this pull request Oct 23, 2025
Merged
@clarfonthey clarfonthey mentioned this pull request Oct 23, 2025
Merged
bors added a commit that referenced this pull request Oct 23, 2025
@bors
Auto merge of #148014 - jhpratt:rollup-aglren3, r=jhpratt
469357e 
Rollup of 3 pull requests

Successful merges:

 - #134316 (Add `String::replace_first` and `String::replace_last`)
 - #147713 (Retire ast::TyAliasWhereClauses.)
 - #148011 (Revert constification of `AsRef for Cow` due to inference failure )

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5d55418 into rust-lang:master Oct 23, 2025
11 checks passed
rust-timer added a commit that referenced this pull request Oct 23, 2025
@rust-timer
Unrolled build for #148011
6ae63b7 
Rollup merge of #148011 - clarfonthey:const-convert-revert, r=oli-obk

Revert constification of `AsRef for Cow` due to inference failure

Reported issue: #147964
Original PR: #145279
`const AsRef` tracking issue: #143773

Should have additional crater run to verify this fixes the issue.
@rustbot rustbot added this to the 1.92.0 milestone Oct 23, 2025
@clarfonthey clarfonthey mentioned this pull request Oct 23, 2025
Open
@cuviper
Copy link
Member

cuviper commented Oct 23, 2025

We approved a revert+backport in the libs meeting: zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 23, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 23, 2025
@Zalathar
Rollup merge of rust-lang#148016 - clarfonthey:const-convert-revert-2…
244b632 
…, r=cuviper

Revert constification of `Borrow` and `Deref for Cow` due to inference failure

Reported issue: rust-lang#147964
Original PR: rust-lang#145279
Previous revert: rust-lang#148011
`const Borrow`/`Deref` tracking issue: rust-lang#143773

Should have additional crater run to verify this fixes the issue.

Since other PR is in the queue, this will need to be rebased after that merges. Also will want a beta nomination.
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 24, 2025
@Zalathar
Rollup merge of rust-lang#148016 - clarfonthey:const-convert-revert-2…
3f40ce5 
…, r=cuviper

Revert constification of `Borrow` and `Deref for Cow` due to inference failure

Reported issue: rust-lang#147964
Original PR: rust-lang#145279
Previous revert: rust-lang#148011
`const Borrow`/`Deref` tracking issue: rust-lang#143773

Should have additional crater run to verify this fixes the issue.

Since other PR is in the queue, this will need to be rebased after that merges. Also will want a beta nomination.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Oct 24, 2025
@bors
Auto merge of #148014 - jhpratt:rollup-aglren3, r=jhpratt
177a9d7 
Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#134316 (Add `String::replace_first` and `String::replace_last`)
 - rust-lang/rust#147713 (Retire ast::TyAliasWhereClauses.)
 - rust-lang/rust#148011 (Revert constification of `AsRef for Cow` due to inference failure )

r? `@ghost`
`@rustbot` modify labels: rollup
@clarfonthey clarfonthey deleted the const-convert-revert branch October 24, 2025 07:34
rust-timer added a commit that referenced this pull request Oct 24, 2025
@rust-timer
Unrolled build for #148016
b2e231a 
Rollup merge of #148016 - clarfonthey:const-convert-revert-2, r=cuviper

Revert constification of `Borrow` and `Deref for Cow` due to inference failure

Reported issue: #147964
Original PR: #145279
Previous revert: #148011
`const Borrow`/`Deref` tracking issue: #143773

Should have additional crater run to verify this fixes the issue.

Since other PR is in the queue, this will need to be rebased after that merges. Also will want a beta nomination.
@cuviper cuviper mentioned this pull request Oct 24, 2025
Merged
@cuviper cuviper modified the milestones: 1.92.0, 1.91.0 Oct 24, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 24, 2025
bors added a commit that referenced this pull request Oct 25, 2025
@bors
Auto merge of #148075 - cuviper:beta-next, r=cuviper
f2b739d 
[beta] backports

- Revert constification of `AsRef for Cow` due to inference failure #148011
- Revert constification of `Borrow` and `Deref for Cow` due to inference failure #148016
- Revert "fix: Filter suggestion parts that match existing code" #148043
- Revert "feat: implement `hash_map!` macro" #148049
- fix panic when rustc tries to reduce intermediate filenames len with utf8 #148018

r? cuviper
bors added a commit that referenced this pull request Oct 25, 2025
@bors
Auto merge of #148075 - cuviper:beta-next, r=cuviper
f2f881b 
[beta] backports

- Revert constification of `AsRef for Cow` due to inference failure #148011
- Revert constification of `Borrow` and `Deref for Cow` due to inference failure #148016
- Revert "fix: Filter suggestion parts that match existing code" #148043
- Revert "feat: implement `hash_map!` macro" #148049
- fix panic when rustc tries to reduce intermediate filenames len with utf8 #148018

r? cuviper
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Oct 27, 2025
@bors
Auto merge of #148014 - jhpratt:rollup-aglren3, r=jhpratt
d4f0607 
Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#134316 (Add `String::replace_first` and `String::replace_last`)
 - rust-lang/rust#147713 (Retire ast::TyAliasWhereClauses.)
 - rust-lang/rust#148011 (Revert constification of `AsRef for Cow` due to inference failure )

r? `@ghost`
`@rustbot` modify labels: rollup
@github-actions github-actions bot mentioned this pull request Oct 30, 2025
Draft
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Oct 31, 2025
@bors
Auto merge of #148014 - jhpratt:rollup-aglren3, r=jhpratt
8d15b5f 
Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#134316 (Add `String::replace_first` and `String::replace_last`)
 - rust-lang/rust#147713 (Retire ast::TyAliasWhereClauses.)
 - rust-lang/rust#148011 (Revert constification of `AsRef for Cow` due to inference failure )

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obk oli-obk

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

7 participants

@clarfonthey @rustbot @oli-obk @bors @cuviper @theemathas @joboet