Skip to content

Conversation

@Zalathar
Copy link
Member

This avoids the need to laboriously pass a test/aux file path into dozens of directive parsing methods that already take a DirectiveLine.

r? jieyouxu

This avoids the need to laboriously pass a test/aux file path into dozens of
directive parsing methods that already take a `DirectiveLine`.
@rustbot
Copy link
Collaborator

rustbot commented Oct 19, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 19, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me once PR CI is green

View changes since this review

@Zalathar
Copy link
Member Author

@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented Oct 19, 2025

📌 Commit 37a0e62 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2025
bors added a commit that referenced this pull request Oct 19, 2025
Rollup of 3 pull requests

Successful merges:

 - #147870 (`std::thread::available_parallelism()` vxworks libc symbol usage.)
 - #147879 (compiletest: Include a file path in `DirectiveLine`)
 - #147880 (Add a triagebot reminder to update rustc-dev-guide docs when modifying compiletest directives)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 905b9da into rust-lang:master Oct 20, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 20, 2025
rust-timer added a commit that referenced this pull request Oct 20, 2025
Rollup merge of #147879 - Zalathar:directive, r=jieyouxu

compiletest: Include a file path in `DirectiveLine`

This avoids the need to laboriously pass a test/aux file path into dozens of directive parsing methods that already take a `DirectiveLine`.

r? jieyouxu
@Zalathar Zalathar deleted the directive branch October 20, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants