Skip to content

Conversation

jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Sep 30, 2025

The diff is trivial, of course, and basically what you already suggested. Mostly dug around a bunch to learn. I hope this is roughly what you had in mind.

Fixes rust-lang/trait-system-refactor-initiative#236.

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 30, 2025
@jdonszelmann jdonszelmann changed the title Bevy outlives bound Fix the bevy implied bounds hack for the next solver Sep 30, 2025
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lcnr
Copy link
Contributor

lcnr commented Sep 30, 2025

@bors delegate+

@bors
Copy link
Collaborator

bors commented Sep 30, 2025

✌️ @jdonszelmann, you can now approve this pull request!

If @lcnr told you to "r=me" after making some further change, please make that change, then do @bors r=@lcnr

@lcnr lcnr added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2025
@jdonszelmann
Copy link
Contributor Author

@bors r=lcnr

@bors
Copy link
Collaborator

bors commented Sep 30, 2025

📌 Commit 80e598b has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 30, 2025
bors added a commit that referenced this pull request Sep 30, 2025
Rollup of 6 pull requests

Successful merges:

 - #143069 (Add fast-path for accessing the current thread id)
 - #146518 (Improve the documentation around `ZERO_AR_DATE`)
 - #146596 (Add a dummy codegen backend)
 - #146617 (Don’t suggest foreign `doc(hidden)` types in "the following other types implement trait" diagnostics)
 - #146635 (cg_llvm: Stop using `as_c_char_ptr` for coverage-related bindings)
 - #147184 (Fix the bevy implied bounds hack for the next solver)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Oct 1, 2025
Rollup of 6 pull requests

Successful merges:

 - #143069 (Add fast-path for accessing the current thread id)
 - #146518 (Improve the documentation around `ZERO_AR_DATE`)
 - #146596 (Add a dummy codegen backend)
 - #146617 (Don’t suggest foreign `doc(hidden)` types in "the following other types implement trait" diagnostics)
 - #146635 (cg_llvm: Stop using `as_c_char_ptr` for coverage-related bindings)
 - #147184 (Fix the bevy implied bounds hack for the next solver)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 598ba1f into rust-lang:master Oct 1, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Oct 1, 2025
Rollup merge of #147184 - jdonszelmann:bevy-outlives-bound, r=lcnr

Fix the bevy implied bounds hack for the next solver

The diff is trivial, of course, and basically what you already suggested. Mostly dug around a bunch to learn. I hope this is roughly what you had in mind.

Fixes rust-lang/trait-system-refactor-initiative#236.

r? `@lcnr`
@rustbot rustbot added this to the 1.92.0 milestone Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bevy_ecs implied bounds hack ICE
4 participants