Skip to content

AutoDeref::final_ty is already resolved #145990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2025
Merged

AutoDeref::final_ty is already resolved #145990

merged 1 commit into from
Aug 30, 2025
+10 −16

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Aug 29, 2025 •
edited
Loading

What is a bool argument doing here :<

The initial value is already resolved

rust/compiler/rustc_hir_analysis/src/autoderef.rs

Line 130 in 41f2b6b

cur_ty: infcx.resolve_vars_if_possible(base_ty),

For builtin_deref we assert that this is still the case

rust/compiler/rustc_hir_analysis/src/autoderef.rs

Line 82 in 41f2b6b

debug_assert_eq!(ty, self.infcx.resolve_vars_if_possible(ty));

While overloaded_deref_ty also resolves at the end

rust/compiler/rustc_hir_analysis/src/autoderef.rs

Line 173 in 41f2b6b

Some(self.infcx.resolve_vars_if_possible(normalized_ty))

@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 29, 2025
@lcnr lcnr changed the title AutoDeref::final_ty never resolve AutoDeref::final_ty is already resolved Aug 29, 2025
@lcnr lcnr force-pushed the final-ty-no-resolve branch from f9a6eb0 to 6fd0e50 Compare August 29, 2025 08:53
@lcnr lcnr mentioned this pull request Aug 29, 2025
Draft
@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 29, 2025

📌 Commit 6fd0e50 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 29, 2025
@matthiaskrgr
Rollup merge of rust-lang#145990 - lcnr:final-ty-no-resolve, r=davidtwco
17b0f54 
`AutoDeref::final_ty` is already resolved

What is a `bool` argument doing here :<

The initial value is already resolved https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L130

For `builtin_deref` we assert that this is still the case https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L82

While `overloaded_deref_ty` also resolves at the end https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L173
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 29, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 29, 2025
@matthiaskrgr
Rollup merge of rust-lang#145990 - lcnr:final-ty-no-resolve, r=davidtwco
418bfbd 
`AutoDeref::final_ty` is already resolved

What is a `bool` argument doing here :<

The initial value is already resolved https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L130

For `builtin_deref` we assert that this is still the case https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L82

While `overloaded_deref_ty` also resolves at the end https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L173
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 29, 2025
@matthiaskrgr
Rollup merge of rust-lang#145990 - lcnr:final-ty-no-resolve, r=davidtwco
0c1ce6d 
`AutoDeref::final_ty` is already resolved

What is a `bool` argument doing here :<

The initial value is already resolved https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L130

For `builtin_deref` we assert that this is still the case https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L82

While `overloaded_deref_ty` also resolves at the end https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L173
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 29, 2025
Closed
bors added a commit that referenced this pull request Aug 29, 2025
@bors
Auto merge of #146014 - matthiaskrgr:rollup-t39vmhf, r=matthiaskrgr
a268e92 
Rollup of 6 pull requests

Successful merges:

 - #144964 (std: clarify `OpenOptions` error for create without write access)
 - #145242 (std: use a TAIT to define `SplitPaths` on UNIX)
 - #145467 (Stabilize `strict_provenance_atomic_ptr` feature)
 - #145990 (`AutoDeref::final_ty` is already resolved)
 - #145991 (std: haiku: fix `B_FIND_PATH_IMAGE_PATH`)
 - #146000 (Improve librustdoc error when a file creation/modification failed)

r? `@ghost`
`@rustbot` modify labels: rollup
tgross35 added a commit to tgross35/rust that referenced this pull request Aug 29, 2025
@tgross35
Rollup merge of rust-lang#145990 - lcnr:final-ty-no-resolve, r=davidtwco
9eb9d7d 
`AutoDeref::final_ty` is already resolved

What is a `bool` argument doing here :<

The initial value is already resolved https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L130

For `builtin_deref` we assert that this is still the case https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L82

While `overloaded_deref_ty` also resolves at the end https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L173
@tgross35 tgross35 mentioned this pull request Aug 29, 2025
Closed
tgross35 added a commit to tgross35/rust that referenced this pull request Aug 30, 2025
@tgross35
Rollup merge of rust-lang#145990 - lcnr:final-ty-no-resolve, r=davidtwco
714bc81 
`AutoDeref::final_ty` is already resolved

What is a `bool` argument doing here :<

The initial value is already resolved https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L130

For `builtin_deref` we assert that this is still the case https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L82

While `overloaded_deref_ty` also resolves at the end https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L173
@tgross35 tgross35 mentioned this pull request Aug 30, 2025
Merged
bors added a commit that referenced this pull request Aug 30, 2025
@bors
Auto merge of #146023 - tgross35:rollup-gbec538, r=tgross35
e004014 
Rollup of 9 pull requests

Successful merges:

 - #145242 (std: use a TAIT to define `SplitPaths` on UNIX)
 - #145467 (Stabilize `strict_provenance_atomic_ptr` feature)
 - #145756 (str: Stabilize `round_char_boundary` feature)
 - #145967 (compiler: Include span of too huge enum with `-Cdebuginfo=2`)
 - #145990 (`AutoDeref::final_ty` is already resolved)
 - #145991 (std: haiku: fix `B_FIND_PATH_IMAGE_PATH`)
 - #146000 (Improve librustdoc error when a file creation/modification failed)
 - #146017 (Mark pipe2 supported in Android)
 - #146022 (compiler-builtins subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4d5ca4c into rust-lang:master Aug 30, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 30, 2025
rust-timer added a commit that referenced this pull request Aug 30, 2025
@rust-timer
Unrolled build for #145990
e7fb271 
Rollup merge of #145990 - lcnr:final-ty-no-resolve, r=davidtwco

`AutoDeref::final_ty` is already resolved

What is a `bool` argument doing here :<

The initial value is already resolved https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L130

For `builtin_deref` we assert that this is still the case https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L82

While `overloaded_deref_ty` also resolves at the end https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L173
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Aug 30, 2025
@bors
Auto merge of #146023 - tgross35:rollup-gbec538, r=tgross35
d62798e 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#145242 (std: use a TAIT to define `SplitPaths` on UNIX)
 - rust-lang/rust#145467 (Stabilize `strict_provenance_atomic_ptr` feature)
 - rust-lang/rust#145756 (str: Stabilize `round_char_boundary` feature)
 - rust-lang/rust#145967 (compiler: Include span of too huge enum with `-Cdebuginfo=2`)
 - rust-lang/rust#145990 (`AutoDeref::final_ty` is already resolved)
 - rust-lang/rust#145991 (std: haiku: fix `B_FIND_PATH_IMAGE_PATH`)
 - rust-lang/rust#146000 (Improve librustdoc error when a file creation/modification failed)
 - rust-lang/rust#146017 (Mark pipe2 supported in Android)
 - rust-lang/rust#146022 (compiler-builtins subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@lcnr lcnr deleted the final-ty-no-resolve branch August 30, 2025 13:08
github-actions bot pushed a commit to rust-lang/compiler-builtins that referenced this pull request Sep 1, 2025
@bors
Auto merge of #146023 - tgross35:rollup-gbec538, r=tgross35
3232a1d 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#145242 (std: use a TAIT to define `SplitPaths` on UNIX)
 - rust-lang/rust#145467 (Stabilize `strict_provenance_atomic_ptr` feature)
 - rust-lang/rust#145756 (str: Stabilize `round_char_boundary` feature)
 - rust-lang/rust#145967 (compiler: Include span of too huge enum with `-Cdebuginfo=2`)
 - rust-lang/rust#145990 (`AutoDeref::final_ty` is already resolved)
 - rust-lang/rust#145991 (std: haiku: fix `B_FIND_PATH_IMAGE_PATH`)
 - rust-lang/rust#146000 (Improve librustdoc error when a file creation/modification failed)
 - rust-lang/rust#146017 (Mark pipe2 supported in Android)
 - rust-lang/rust#146022 (compiler-builtins subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lcnr @rustbot @davidtwco @bors