std: clarify OpenOptions error for create without write access

[0xdeafbeef]

Fixes #140621

[rustbot]

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

⚠️ Warning ⚠️

• There are issue links (such as #123) in the commit messages of the following commits.
  Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

  • 9332c13

• This PR is based on an upstream commit that is 618 days old.

  It's recommended to update your branch according to the rustc-dev-guide.

[0xdeafbeef]

oops somehow i've untracked remote master, will rebase rn. Sorry

[0xdeafbeef]

@ibraheemdev friendly ping :)

[ibraheemdev]

Do the tests pass before applying this change (is this a change in behavior)?

[0xdeafbeef]

Do the tests pass before applying this change (is this a change in behavior)?

I've only changed the error message; the behavior is the same.

https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=7b7613497935f70189a3118735e491cf

You can't do anything meaningful when setting these flags, except trigger a validation error.

With my changes, you still get a validation error as before, but now it tells you what’s wrong instead of making you open strace/gdb :)

[ibraheemdev]

I'm slightly concerned about keeping the message consistent across platforms, but we seem to do the same thing for other error conditions, so this seems fine. @bors r+ rollup

[bors]

📌 Commit de61934 has been approved by ibraheemdev

It is now in the queue for this repository.

[tgross35]

Think this may have failed #146014 (comment)

@bors r-
@bors2 try jobs=aarch64-msvc-1

[rust-bors]

💔 Test for 4d9eaea failed: CI. Failed jobs:

• try - aarch64-msvc-1 (web logs, extended logs)

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[0xdeafbeef]

it failed because of different error! behavior on unix and windows

rust/library/std/src/fs/tests.rs

Lines 48 to 64 in 846e377

	macro_rules! error {
	($e:expr, $s:expr) => {
	match $e {
	Ok(_) => panic!("Unexpected success. Should've been: {:?}", $s),
	Err(ref err) => {
	assert!(err.raw_os_error() == Some($s), "`{}` did not have a code of `{}`", err, $s)
	}
	}
	};
	}
	#[cfg(unix)]
	macro_rules! error {
	($e:expr, $s:expr) => {
	error_contains!($e, $s)
	};
	}

Now i directly use error_contains!

[0xdeafbeef]

@bors2 try jobs=aarch64-msvc-1

[rust-bors]

@0xdeafbeef: 🔑 Insufficient privileges: not in try users

[0xdeafbeef]

@tgross35 can you trigger windows build? should pass now

[tgross35]

@bors2 try jobs=aarch64-msvc-1

[rust-bors]

☀️ Try build successful (CI)
Build commit: 86c30e6 (86c30e619d775841d7969fb536b34ef309901a4d, parent: 0f506968010fa987b0d134034d0ccab9eecd9120)

[tgross35]

@bors r=ibraheemdev

[bors]

📌 Commit 0858b14 has been approved by ibraheemdev

It is now in the queue for this repository.