Remove unnecessary [dependencies.*] entries.
#145946
Merged
+3
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Cargo style guide says to put dependencies on a single line if they fit.
This comment was marked as outdated.
This comment was marked as outdated.
rustbot
added
S-waiting-on-review
|
I noticed this when working on the follow-up to #145740. The The Cargo style guide gives this example: [dependencies.extremely_long_crate_name_goes_here]
path = "extremely_long_path_name_goes_right_here"
version = "4.5.6"I wish it instead was this: extremely_long_crate_name_goes_here = {
path = "extremely_long_path_name_goes_right_here",
version = "4.5.6"
}Seems silly to require an entirely different syntax when something doesn't fit on a single line :( |
|
Oh I completely agree with this, I try to use the table syntax as little as possible. And indeed if it just fits it feels like a no brainer. Awesome! Tidy already passed and I don't see how any other ci step could be broken by this so I'll just r+ it directly :) @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 28, 2025
Rollup of 5 pull requests Successful merges: - #145382 (Add assembly test for `-Zreg-struct-return` option) - #145746 (Fix STD build failing for target_os = "espidf") - #145826 (Use AcceptContext in AttribueParser::check_target) - #145894 (Ensure the coordinator thread terminates before its channels drop) - #145946 (Remove unnecessary `[dependencies.unicode-properties]` entries.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Aug 28, 2025
Rollup merge of #145946 - nnethercote:cargo-style, r=jdonszelmann Remove unnecessary `[dependencies.unicode-properties]` entries. The Cargo style guide says to put dependencies on a single line if they fit. r? `@jdonszelmann`
nnethercote
changed the title
[dependencies.unicode-properties] entries.[dependencies.*] entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cargo style guide says to put dependencies on a single line if they fit.
r? @jdonszelmann