Fix STD build failing for target_os = "espidf" #145746
Open
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
|
r? @ibraheemdev |
ivmarkov
force-pushed
the
fix-nofollow-espidf
branch
from
06971ea to
8e5b591
Compare
ivmarkov
force-pushed
the
fix-nofollow-espidf
branch
from
8e5b591 to
6e5a427
Compare
|
@ibraheemdev Would you have time to review, or shall I reassign to somebody else? |
|
Thanks for the quick fix. @bors r+ rollup |
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 28, 2025
…raheemdev Fix STD build failing for target_os = "espidf" A regression from rust-lang#142938 cc `@lolbinarycat` cc `@ibraheemdev` ESP-IDF (and a few other embedded Tier-3 systems) is considered `cfg(unix)`, but it does not have the `O_NOFOLLOW` flag because neither of its three supported filesystems (FATFS, LitteLF and Spiffs) has symbolic links in the first place. What this fix does is to keep the `set_permissions_nofollow` method available and non-failing for ESP-IDF, but it behaves as if no `O_NONFOLLOW` was set. This should be fine as there is nothing to follow in the first place, as there are no symbolic links there. EDIT: Also added the same fix for Horizon, as requested by `@Meziu.`
bors
added a commit
that referenced
this pull request
Aug 28, 2025
Rollup of 5 pull requests Successful merges: - #145382 (Add assembly test for `-Zreg-struct-return` option) - #145746 (Fix STD build failing for target_os = "espidf") - #145826 (Use AcceptContext in AttribueParser::check_target) - #145894 (Ensure the coordinator thread terminates before its channels drop) - #145946 (Remove unnecessary `[dependencies.unicode-properties]` entries.) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression from #142938
cc @lolbinarycat
cc @ibraheemdev
ESP-IDF (and a few other embedded Tier-3 systems) is considered
cfg(unix), but it does not have theO_NOFOLLOWflag because neither of its three supported filesystems (FATFS, LitteLF and Spiffs) has symbolic links in the first place.What this fix does is to keep the
set_permissions_nofollowmethod available and non-failing for ESP-IDF, but it behaves as if noO_NONFOLLOWwas set. This should be fine as there is nothing to follow in the first place, as there are no symbolic links there.EDIT: Also added the same fix for Horizon, as requested by @Meziu.