Linting public reexport of private dependencies #143856

mladedav · 2025-07-12T21:45:58Z

Part of public/private dependencies #44663
Partially addresses #71043

I'm adding a warning for reexports of private dependencies into rustc_resolve. I get that this should not be a warning, but should instead be a lint to be controlled by the feature gate, but I did not figure out how exactly to do that at that point. I tried doing the same thing as is done in rustc_privacy, but the linting system is not ready yet as far as I understand the error I got, so I made a warning for now instead. Some guidance on how to emit lints with dcx would be appreciated.

This also sets the std_detect crate as a public dependency of std because some macros are reexported from there. I did not check closer, but the other option may be to allow the specific reexports instead.

rustbot · 2025-07-12T21:46:02Z

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler-errors · 2025-07-12T21:46:54Z

r? petrochenkov perhaps

petrochenkov · 2025-07-14T18:22:27Z

I'm adding a warning for reexports of private dependencies into rustc_resolve. I get that this should not be a warning, but should instead be a lint to be controlled by the feature gate, but I did not figure out how exactly to do that at that point. I tried doing the same thing as is done in rustc_privacy, but the linting system is not ready yet as far as I understand the error I got, so I made a warning for now instead. Some guidance on how to emit lints with dcx would be appreciated.

See calls to buffer_lint in rustc_resolve, they can be used as examples.

compiler/rustc_resolve/src/imports.rs

mladedav · 2025-07-14T20:41:34Z

@rustbot label -S-waiting-on-author +S-waiting-on-review

compiler/rustc_resolve/src/imports.rs

petrochenkov · 2025-07-15T13:55:03Z

Thanks!
@bors r+

bors · 2025-07-15T13:55:06Z

📌 Commit d627e25 has been approved by petrochenkov

It is now in the queue for this repository.

…trochenkov Linting public reexport of private dependencies Part of public/private dependencies rust-lang#44663 Partially addresses rust-lang#71043 I'm adding a warning for reexports of private dependencies into `rustc_resolve`. I get that this should not be a warning, but should instead be a lint to be controlled by the feature gate, but I did not figure out how exactly to do that at that point. I tried doing the same thing as is done in `rustc_privacy`, but the linting system is not ready yet as far as I understand the error I got, so I made a warning for now instead. Some guidance on how to emit lints with `dcx` would be appreciated. This also sets the `std_detect` crate as a public dependency of `std` because some macros are reexported from there. I did not check closer, but the other option may be to allow the specific reexports instead.

Rollup of 11 pull requests Successful merges: - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - #143678 (Added error for invalid char cast) - #143793 (Opaque type collection: Guard against endlessly recursing free alias types) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143829 (Trim `BorrowedCursor` API) - #143856 (Linting public reexport of private dependencies) - #143891 (Port `#[coverage]` to the new attribute system) - #143914 (Reword mismatched-lifetime-syntaxes text based on feedback) - #143922 (Improve path segment joining) - #143926 (Remove deprecated fields in bootstrap) - #143975 (type_id_eq: check that the hash fully matches the type) r? `@ghost` `@rustbot` modify labels: rollup

…trochenkov Linting public reexport of private dependencies Part of public/private dependencies rust-lang#44663 Partially addresses rust-lang#71043 I'm adding a warning for reexports of private dependencies into `rustc_resolve`. I get that this should not be a warning, but should instead be a lint to be controlled by the feature gate, but I did not figure out how exactly to do that at that point. I tried doing the same thing as is done in `rustc_privacy`, but the linting system is not ready yet as far as I understand the error I got, so I made a warning for now instead. Some guidance on how to emit lints with `dcx` would be appreciated. This also sets the `std_detect` crate as a public dependency of `std` because some macros are reexported from there. I did not check closer, but the other option may be to allow the specific reexports instead.

Rollup of 15 pull requests Successful merges: - #142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test) - #143388 (Various refactors to the LTO handling code) - #143409 (Enable xgot feature for mips64 musl targets) - #143592 (UWP: link ntdll functions using raw-dylib) - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - #143678 (Added error for invalid char cast) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143829 (Trim `BorrowedCursor` API) - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests) - #143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test) - #143856 (Linting public reexport of private dependencies) - #143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates) - #143922 (Improve path segment joining) - #143964 (Fix handling of SCRIPT_ARG in docker images) - #144016 (trait_sel: `MetaSized` always holds temporarily) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - #142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test) - #143388 (Various refactors to the LTO handling code) - #143409 (Enable xgot feature for mips64 musl targets) - #143592 (UWP: link ntdll functions using raw-dylib) - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - #143678 (Added error for invalid char cast) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143829 (Trim `BorrowedCursor` API) - #143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test) - #143856 (Linting public reexport of private dependencies) - #143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates) - #143922 (Improve path segment joining) - #143964 (Fix handling of SCRIPT_ARG in docker images) - #144002 (Update poison.rs) - #144016 (trait_sel: `MetaSized` always holds temporarily) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143856 - mladedav:dm/private-reexport, r=petrochenkov Linting public reexport of private dependencies Part of public/private dependencies #44663 Partially addresses #71043 I'm adding a warning for reexports of private dependencies into `rustc_resolve`. I get that this should not be a warning, but should instead be a lint to be controlled by the feature gate, but I did not figure out how exactly to do that at that point. I tried doing the same thing as is done in `rustc_privacy`, but the linting system is not ready yet as far as I understand the error I got, so I made a warning for now instead. Some guidance on how to emit lints with `dcx` would be appreciated. This also sets the `std_detect` crate as a public dependency of `std` because some macros are reexported from there. I did not check closer, but the other option may be to allow the specific reexports instead.

rustbot assigned compiler-errors Jul 12, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 12, 2025

rustbot assigned petrochenkov and unassigned compiler-errors Jul 12, 2025

This comment was marked as resolved.

Sign in to view

petrochenkov reviewed Jul 14, 2025

View reviewed changes

compiler/rustc_resolve/src/imports.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2025

mladedav force-pushed the dm/private-reexport branch from 070e53d to d2fc98c Compare July 14, 2025 20:38

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 14, 2025

petrochenkov reviewed Jul 15, 2025

View reviewed changes

compiler/rustc_resolve/src/imports.rs Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2025

rustc_resolve: rename check_hidden_glob_reexports to lint_reexports

4a77a62

mladedav force-pushed the dm/private-reexport branch 2 times, most recently from a0d9f53 to d6ea20e Compare July 15, 2025 13:39

mladedav added 2 commits July 15, 2025 15:44

Implement resolver warnings about reexporting private dependencies

8b868fa

make std_detect public dependency of std

d627e25

mladedav force-pushed the dm/private-reexport branch from d6ea20e to d627e25 Compare July 15, 2025 13:46

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2025

mladedav mentioned this pull request Jul 16, 2025

Lint exported_private_dependencies misses public dependency via trait impl #71043

Open

matthiaskrgr mentioned this pull request Jul 16, 2025

Rollup of 12 pull requests #144035

Closed

matthiaskrgr mentioned this pull request Jul 16, 2025

Rollup of 12 pull requests #144036

Closed

matthiaskrgr mentioned this pull request Jul 16, 2025

Rollup of 11 pull requests #144038

Closed

fmease mentioned this pull request Jul 16, 2025

Rollup of 15 pull requests #144041

Closed

fmease mentioned this pull request Jul 17, 2025

Rollup of 15 pull requests #144044

Merged

bors merged commit 36a362b into rust-lang:master Jul 17, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Linting public reexport of private dependencies #143856

Linting public reexport of private dependencies #143856

Uh oh!

mladedav commented Jul 12, 2025 •

edited by rustbot

Loading

Uh oh!

rustbot commented Jul 12, 2025

Uh oh!

compiler-errors commented Jul 12, 2025

Uh oh!

This comment was marked as resolved.

petrochenkov commented Jul 14, 2025

Uh oh!

Uh oh!

mladedav commented Jul 14, 2025

Uh oh!

Uh oh!

petrochenkov commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

Uh oh!

Uh oh!

Linting public reexport of private dependencies #143856

Linting public reexport of private dependencies #143856

Uh oh!

Conversation

mladedav commented Jul 12, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 12, 2025

Uh oh!

compiler-errors commented Jul 12, 2025

Uh oh!

This comment was marked as resolved.

petrochenkov commented Jul 14, 2025

Uh oh!

Uh oh!

mladedav commented Jul 14, 2025

Uh oh!

Uh oh!

petrochenkov commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

Uh oh!

Uh oh!

mladedav commented Jul 12, 2025 •

edited by rustbot

Loading