ci cleanup: rustdoc-gui-test now installs browser-ui-test #143851
Merged
+44
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
bootstrap-node_modules
branch
from
c070840 to
5bc18df
Compare
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
bootstrap-node_modules
branch
from
5bc18df to
4254f64
Compare
Kobzol
reviewed
Jul 12, 2025
|
r? @Kobzol |
lolbinarycat
force-pushed
the
bootstrap-node_modules
branch
2 times, most recently
from
8a1869c to
4028b6d
Compare
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
bootstrap-node_modules
branch
from
4028b6d to
2f62ee4
Compare
This comment has been minimized.
This comment has been minimized.
| Err(e) => eprintln!("Couldn't find the CI browser-ui-test version: {:?}", e), | ||
| } | ||
| fn get_desired_browser_ui_test_version(src: &Path) -> Result<String, io::Error> { | ||
| Ok("0.21.1") |
There was a problem hiding this comment.
Don't we have a package.json already? If not, please add a FIXME comment to update/remove this function once we make use of package.json.
There was a problem hiding this comment.
no, that's being added in a future PR that I want to make this CI change before.
once we have a package.json we could update this function to use npm update, no? would that install a specific package according to the version in the package.json ..?
I suppose probably we'll just use npm install, though.
lolbinarycat
commented
Jul 14, 2025
lolbinarycat
force-pushed
the
bootstrap-node_modules
branch
from
2f62ee4 to
4d4da0e
Compare
|
Looks good! You can r=me once CI is green. @bors delegate+ |
|
✌️ @lolbinarycat, you can now approve this pull request! If @Kobzol told you to " |
lolbinarycat
force-pushed
the
bootstrap-node_modules
branch
from
4d4da0e to
4deb8eb
Compare
this removes the need for --unsafe-perm in the Dockerfile.
lolbinarycat
force-pushed
the
bootstrap-node_modules
branch
from
4deb8eb to
bbb114e
Compare
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
Jul 16, 2025
…s, r=Kobzol ci cleanup: rustdoc-gui-test now installs browser-ui-test this removes the need for --unsafe-perm in the Dockerfile. cc ``@GuillaumeGomez`` ``@Kobzol``
bors
added a commit
that referenced
this pull request
Jul 17, 2025
Rollup of 15 pull requests Successful merges: - #142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test) - #143388 (Various refactors to the LTO handling code) - #143409 (Enable xgot feature for mips64 musl targets) - #143592 (UWP: link ntdll functions using raw-dylib) - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - #143678 (Added error for invalid char cast) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143829 (Trim `BorrowedCursor` API) - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests) - #143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test) - #143856 (Linting public reexport of private dependencies) - #143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates) - #143922 (Improve path segment joining) - #143964 (Fix handling of SCRIPT_ARG in docker images) - #144016 (trait_sel: `MetaSized` always holds temporarily) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jul 17, 2025
Rollup of 15 pull requests Successful merges: - #142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test) - #143388 (Various refactors to the LTO handling code) - #143409 (Enable xgot feature for mips64 musl targets) - #143592 (UWP: link ntdll functions using raw-dylib) - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - #143678 (Added error for invalid char cast) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143829 (Trim `BorrowedCursor` API) - #143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test) - #143856 (Linting public reexport of private dependencies) - #143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates) - #143922 (Improve path segment joining) - #143964 (Fix handling of SCRIPT_ARG in docker images) - #144002 (Update poison.rs) - #144016 (trait_sel: `MetaSized` always holds temporarily) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 17, 2025
Rollup merge of #143851 - lolbinarycat:bootstrap-node_modules, r=Kobzol ci cleanup: rustdoc-gui-test now installs browser-ui-test this removes the need for --unsafe-perm in the Dockerfile. cc ```@GuillaumeGomez``` ```@Kobzol```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes the need for --unsafe-perm in the Dockerfile.
cc @GuillaumeGomez @Kobzol