Remove astconv usage in diagnostic #107779
Merged
+67
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 8, 2023
…ckh726 Remove astconv usage in diagnostic Fixes rust-lang#107775 Location of the test sucks, I know, but I needed to put it somewhere 😓 The issue here is that the root cause of the issue has nothing to do with what's being tested, so I couldn't really give it a better name. Oh well.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 8, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107656 (Bump rust-installer) - rust-lang#107757 (Allow automatically creating vscode `settings.json` with `x setup`) - rust-lang#107769 (Rename `PointerSized` to `PointerLike`) - rust-lang#107770 (rustdoc: use a newline instead of `<br>` to format code headers) - rust-lang#107771 (Tweak ICE message) - rust-lang#107773 (Clearly signal purpose of the yaml template) - rust-lang#107776 (Docs: Fix format of headings in String::reserve) - rust-lang#107779 (Remove astconv usage in diagnostic) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107775
Location of the test sucks, I know, but I needed to put it somewhere 😓
The issue here is that the root cause of the issue has nothing to do with what's being tested, so I couldn't really give it a better name. Oh well.