Skip to content

Conversation

jonhoo
Copy link
Contributor

@jonhoo jonhoo commented Feb 4, 2023

Makes generation of manifest.in deterministic:
rust-lang/rust-installer#120

Makes generation of `manifest.in` deterministic:
rust-lang/rust-installer#120
@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 4, 2023
@jonhoo
Copy link
Contributor Author

jonhoo commented Feb 4, 2023

r? @Mark-Simulacrum

probably given he approved the initial rust-installer PR

@Mark-Simulacrum
Copy link
Member

@bors try

Want to produce a dev-static nightly just in case, but not expecting any problems.

@bors
Copy link
Collaborator

bors commented Feb 4, 2023

⌛ Trying commit 50e2509 with merge 038edaecc9e8afdcc5d38bc8331da43654143eba...

@bors
Copy link
Collaborator

bors commented Feb 4, 2023

☀️ Try build successful - checks-actions
Build commit: 038edaecc9e8afdcc5d38bc8331da43654143eba (038edaecc9e8afdcc5d38bc8331da43654143eba)

@Mark-Simulacrum
Copy link
Member

Kicked off dev-static nightly...

@Mark-Simulacrum
Copy link
Member

dev-static nightly published, seems to install OK for me so going to go ahead and approve. @bors r+

@bors
Copy link
Collaborator

bors commented Feb 7, 2023

📌 Commit 50e2509 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 8, 2023
…-Simulacrum

Bump rust-installer

Makes generation of `manifest.in` deterministic:
rust-lang/rust-installer#120
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 8, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#107656 (Bump rust-installer)
 - rust-lang#107757 (Allow automatically creating vscode `settings.json` with `x setup`)
 - rust-lang#107769 (Rename `PointerSized` to `PointerLike`)
 - rust-lang#107770 (rustdoc: use a newline instead of `<br>` to format code headers)
 - rust-lang#107771 (Tweak ICE message)
 - rust-lang#107773 (Clearly signal purpose of the yaml template)
 - rust-lang#107776 (Docs: Fix format of headings in String::reserve)
 - rust-lang#107779 (Remove astconv usage in diagnostic)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 00efb0c into rust-lang:master Feb 8, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 8, 2023
@jonhoo jonhoo deleted the bump-rust-installer branch February 11, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants