Use more concrete explanation for methods #6124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show some code rather than "a single method call".
|
r? @Manishearth (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 7021d70 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 6, 2020
Use more concrete explanation for methods *Please keep the line below* changelog: none
|
💔 Test failed - checks-action_test |
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 7021d70 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 6, 2020
Use more concrete explanation for methods *Please keep the line below* changelog: none
|
💔 Test failed - checks-action_dev_test |
|
@bors retry (this time remembering, that I don't have to reapprove this!) |
bors
added a commit
that referenced
this pull request
Oct 6, 2020
Use more concrete explanation for methods *Please keep the line below* changelog: none
|
💔 Test failed - checks-action_test |
|
@bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please keep the line below
changelog: none