Skip to content

Conversation

Mark-Simulacrum
Copy link
Member

Specifically, this revises the clippy integration to utilize a new
callback to register its lints, as the prior editing of lint store in
Session is no longer possible.


changelog: none

@Mark-Simulacrum
Copy link
Member Author

This is for rust-lang/rust#65193. cc @Manishearth

@Mark-Simulacrum
Copy link
Member Author

This will need another pass since we need to register_lints as well for all the lints -- if you have thoughts on how to do that I'd be happy to do so. Previously this was implicit but that's no longer the case.

@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 11, 2019
@Manishearth
Copy link
Member

Got a try build we can rustup-toolchain-install-master to test with?

@Manishearth
Copy link
Member

A lot of lib.rs is autogenerated with update-lints, so we can update that to do whatever registry you need

@Mark-Simulacrum Mark-Simulacrum force-pushed the clippy-up-lintstore-lockless branch from 004a3a8 to 50a082d Compare October 11, 2019 12:46
@Mark-Simulacrum
Copy link
Member Author

Attempted to update update-lints to do the right thing and pushed relevant changes. Working on a try build in the rust PR.

@bors
Copy link
Contributor

bors commented Oct 14, 2019

☔ The latest upstream changes (presumably #4560) made this pull request unmergeable. Please resolve the merge conflicts.

@flip1995 flip1995 mentioned this pull request Oct 22, 2019
@matthiaskrgr
Copy link
Member

rust-lang/rust#65193 was merged so we need this now

Specifically, this revises the clippy integration to utilize a new
callback to register its lints, as the prior editing of lint store in
Session is no longer possible.
@flip1995 flip1995 force-pushed the clippy-up-lintstore-lockless branch from 50a082d to ef02e3a Compare October 24, 2019 10:04
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for final review

@tesuji
Copy link
Contributor

tesuji commented Oct 24, 2019

You need to revert 974a05b to rustup rustc-dev component.

@flip1995
Copy link
Member

Oh so bors decided to finally merge this PR 😄

On it 👍

@flip1995
Copy link
Member

@bors treeclosed=10 p=10

@flip1995 flip1995 force-pushed the clippy-up-lintstore-lockless branch from 5713240 to b261664 Compare October 24, 2019 12:39
@flip1995
Copy link
Member

flip1995 commented Oct 24, 2019

Now we should be good (at least cargo test passed locally)

@Mark-Simulacrum
Copy link
Member Author

(Let me know if you need anything from me here)

@tesuji
Copy link
Contributor

tesuji commented Oct 24, 2019

CI passed.

@phansch
Copy link
Contributor

phansch commented Oct 24, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Oct 24, 2019

📌 Commit b261664 has been approved by phansch

@bors
Copy link
Contributor

bors commented Oct 24, 2019

⌛ Testing commit b261664 with merge 8ab24d7...

bors added a commit that referenced this pull request Oct 24, 2019
…=phansch

Update clippy for latest rustc changes

Specifically, this revises the clippy integration to utilize a new
callback to register its lints, as the prior editing of lint store in
Session is no longer possible.

---

changelog: none
@bors
Copy link
Contributor

bors commented Oct 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 8ab24d7 to master...

@phansch
Copy link
Contributor

phansch commented Oct 24, 2019

@bors treeclose-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants