Fix const eval reading wrong size for array index values #21041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10: Allow type aliases in extern blocks r=jonas-schievink a=jonas-schievink This is for the unstable feature rust-lang/rust#43467, which rustc uses internally Co-authored-by: Jonas Schievink <[email protected]>
11: Allow both const & async modifiers r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
12: Fix .gitignore r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
I don't really look at the results of the benchmarks anyway, so having them in the repo creates a false sense of benchmarkdness. If I get to implementing proper benchmarking, I'd probably stay away from criterion -- we need something much much simpler for this crate.
23: modernize r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
The Travis workflow was deleted in 1150aa9
Move towards upstream `macro_rules!` model
It's unclear if this is worthwhile, and this requires a lot of changes in r-a
16: Add `MacroDef` for "Macros 2.0" r=matklad a=jonas-schievink Co-authored-by: Jonas Schievink <[email protected]>
perf: Reduce memory usage of symbol index
internal: Move `SymbolsDatabase` over to new salsa style
Rename `downcast_[ref|mut]_unchecked` -> `downcast_unchecked_[ref|mut]`
perf: Only populate public items in dependency symbol index
…tmrx lib: Bump editions to 2024 and remove legacy files
Example
---
```rust
fn main() { unsafe {1}.$0 }
```
**Before this PR**
```rust
fn main() { const unsafe {{1}} }
```
**After this PR**
```rust
fn main() { const { unsafe {1} } }
```
Book>Contributing>Testing: Fix typos and distracting word choices
"msg" adds noise to `expect` and crossbeam's `Sender`. "op" adds noise to `map_err`
…x-with-modifier-block Fix .const missing block on with modifier block
Fix not parse never type in inherent impl
Add guard support for replace_if_let_with_match
support rename after adding loop label
Add "msg" and "op" to hidden inlay parameter names
…ture Fix removed feature `doc_auto_cfg` for smol_str lib
rustbot
added
the
S-waiting-on-review
Contributor
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
There was a problem hiding this comment.
That... shouldn't change? I don't understand why this change is fixing anything. We're reading a usize, the only index type can be usize, why does it matter if we get its size as self.ptr_size() or as op_interval.size? I want to understand better the fix before I approve it.
Contributor
|
Can you check if the fix is working in a full IDE, and/or if the test is passing without the fix? |
Member
|
Yeah, the added tests are passing indeed without the changes in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
37 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.