minor: Rename downcast_[ref|mut]_unchecked -> downcast_unchecked_[ref|mut]
#20909
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lnicola
reviewed
Oct 25, 2025
lnicola
approved these changes
Oct 25, 2025
Member
|
I think this could be merged only after at least approved on rust-lang/rust. Though it's just an inherent method name change in rust-analyzer side but keeping them synced with |
rustbot
removed
the
S-waiting-on-review
lnicola
changed the title
downcast_[ref|mut]_unchecked -> downcast_unchecked_[ref|mut]downcast_[ref|mut]_unchecked -> downcast_unchecked_[ref|mut]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An accompanying PR to rust-lang/rust#148079 which keeps these Rust Analyzer names consistent with
core.Intent
Renames
downcast_[ref|mut]_uncheckedtodowncast_unchecked_[ref|mut]because we want to emphasise that it is the downcast that is unsafe, not the aliasing per:rust-lang/rust#90850 (comment)
Tracking Issue: rust-lang/rust#90850 (comment)
cc @marc0246