Skip to content

Conversation

@Veykril
Copy link
Member

@Veykril Veykril commented Aug 26, 2024

Most of our mbe hir-def tests don't actually do anything name res relevant, we can (and should) move those down the stack into mbe/hir-expand.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2024
@Veykril Veykril changed the title minor: Reduce friction for updating minicore internal: Lay basic ground work for standalone mbe tests Aug 26, 2024
@Veykril
Copy link
Member Author

Veykril commented Aug 26, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Aug 26, 2024

📌 Commit 68e81f9 has been approved by Veykril

It is now in the queue for this repository.

bors added a commit that referenced this pull request Aug 26, 2024
internal: Lay basic ground work for standalone mbe tests

Most of our mbe hir-def tests don't actually do anything name res relevant, we can (and should) move those down the stack into `mbe/hir-expand`.
@bors
Copy link
Contributor

bors commented Aug 26, 2024

⌛ Testing commit 68e81f9 with merge c1150dd...

@bors
Copy link
Contributor

bors commented Aug 26, 2024

💔 Test failed - checks-actions

@Veykril
Copy link
Member Author

Veykril commented Aug 26, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Aug 26, 2024

📌 Commit c8c5960 has been approved by Veykril

It is now in the queue for this repository.

bors added a commit that referenced this pull request Aug 26, 2024
internal: Lay basic ground work for standalone mbe tests

Most of our mbe hir-def tests don't actually do anything name res relevant, we can (and should) move those down the stack into `mbe/hir-expand`.
@bors
Copy link
Contributor

bors commented Aug 26, 2024

⌛ Testing commit c8c5960 with merge 210b40d...

@bors
Copy link
Contributor

bors commented Aug 26, 2024

💔 Test failed - checks-actions

@bors
Copy link
Contributor

bors commented Aug 29, 2024

☔ The latest upstream changes (presumably #17814) made this pull request unmergeable. Please resolve the merge conflicts.

@Veykril
Copy link
Member Author

Veykril commented Sep 1, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Sep 1, 2024

📌 Commit 4502a60 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 1, 2024

⌛ Testing commit 4502a60 with merge 779d9ee...

@bors
Copy link
Contributor

bors commented Sep 1, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 779d9ee to master...

@bors bors merged commit 779d9ee into rust-lang:master Sep 1, 2024
@Veykril Veykril deleted the mbe-tests branch September 1, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants