feat: Implement object safety and its hovering hint #17814

ShoyuVanilla · 2024-08-06T18:20:07Z

Resolves #17779

bors · 2024-08-08T13:53:54Z

☔ The latest upstream changes (presumably #17832) made this pull request unmergeable. Please resolve the merge conflicts.

ShoyuVanilla · 2024-08-10T06:16:18Z

It might take some time because I'm having difficulties re-implementing some functionality in rustc into r-a 😅 (I think I would do it eventually)

bors · 2024-08-15T07:19:36Z

☔ The latest upstream changes (presumably #17893) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2024-08-23T09:47:00Z

☔ The latest upstream changes (presumably #17936) made this pull request unmergeable. Please resolve the merge conflicts.

ShoyuVanilla · 2024-08-25T15:50:09Z

I think that basic implementation is complete. Now it's test time

crates/test-utils/src/minicore.rs

crates/hir-ty/src/object_safety.rs

ShoyuVanilla · 2024-08-26T08:11:01Z

While testing this plugged into here;

rust-analyzer/crates/hir-ty/src/chalk_db.rs

Lines 384 to 387 in 7106cd3

    
           fn is_object_safe(&self, _trait_id: chalk_ir::TraitId<Interner>) -> bool { 
        
               // FIXME: implement actual object safety 
        
               true 
        
           }

I've found some minor mistakes in my implementation and fixes for them 😅 (All the test are green in my local revision with the above things applied)
I'll push them some hours later

bors · 2024-08-26T09:03:57Z

☔ The latest upstream changes (presumably #17941) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2024-08-27T06:35:47Z

☔ The latest upstream changes (presumably #17972) made this pull request unmergeable. Please resolve the merge conflicts.

ShoyuVanilla · 2024-08-27T12:20:46Z

crates/test-utils/src/minicore.rs

+                fn take(self, n: usize) -> crate::iter::Take<Self>
+                where
+                    Self: Sized,
+                {


std has this bound, too (and without this, Iterator is not object safe)

crates/ide/src/hover/render.rs

ShoyuVanilla · 2024-08-27T12:26:21Z

crates/hir-ty/src/object_safety/tests.rs

I brought every relevant test from https://github.com/rust-lang/rust/tree/ae9f5019f9ce6eb3ecd96206ade4a612efe20fd5/tests/ui/object-safety except one with HRTB - it's still checked as object unsafe as it is in rustc but reason is different because we don't support HRBT yet -

ShoyuVanilla · 2024-08-27T12:33:25Z

Things to do after this(not right after 😅 except the first one);

Implement diagnostics for E0038
Implement diagnostics for non-dispatchable item usage in the trait object like

trait Foo {
    fn foo(&self)
    where
        Self: Sized;
}

fn test(x: &dyn Foo) {
    x.foo();
      ^^^
}

(Maybe) Implement RTPITIT in similar way as in rustc and check for object safety in that way
Implement HRBT and check object safety for it

crates/ide/src/hover/render.rs

crates/hir-ty/src/db.rs

Veykril · 2024-08-29T13:11:46Z

crates/ide/src/hover/render.rs

+                name.as_str()
+            );
+            let desc = match mvc {
+                MethodViolationCode::StaticMethod => "static (no receiver parameter)",


Suggested change

MethodViolationCode::StaticMethod => "static (no receiver parameter)",

MethodViolationCode::StaticMethod => "missing a receiver",

static isn't too descriptive I think (and might confuse people with a static item)

Veykril · 2024-08-29T13:11:51Z

crates/ide/src/hover/render.rs

+            let name = hir::Function::from(func).name(db);
+            format_to!(
+                buf,
+                "has a method `{}` that is non dispatchable because of;\n//   - ",


Suggested change

"has a method `{}` that is non dispatchable because of;\n// - ",

"has a method `{}` that is non dispatchable because of:\n// - ",

Veykril · 2024-08-29T13:12:44Z

crates/ide/src/hover/render.rs

+                MethodViolationCode::ReferencesImplTraitInTrait => {
+                    "the return type contains `impl Trait`"
+                }
+                MethodViolationCode::AsyncFn => "async",


Suggested change

MethodViolationCode::AsyncFn => "async",

MethodViolationCode::AsyncFn => "being async",

Veykril · 2024-08-29T13:13:06Z

crates/ide/src/hover/render.rs

+                MethodViolationCode::WhereClauseReferencesSelf => {
+                    "a where clause references `Self`"
+                }
+                MethodViolationCode::Generic => "a Generic parameter other than lifetime",


Suggested change

MethodViolationCode::Generic => "a Generic parameter other than lifetime",

MethodViolationCode::Generic => "a non-lifetime generic parameter",

Veykril · 2024-08-29T13:13:15Z

crates/ide/src/hover/render.rs

+                    "a where clause references `Self`"
+                }
+                MethodViolationCode::Generic => "a Generic parameter other than lifetime",
+                MethodViolationCode::UndispatchableReceiver => "the non dispatchable receiver type",


Suggested change

MethodViolationCode::UndispatchableReceiver => "the non dispatchable receiver type",

MethodViolationCode::UndispatchableReceiver => "a non-dispatchable receiver type",

Veykril · 2024-08-29T13:14:57Z

Couple of wording nits, otherwise lgtm!
@bors delegate+

bors · 2024-08-29T13:15:00Z

✌️ @ShoyuVanilla, you can now approve this pull request!

If @Veykril told you to "r=me" after making some further change, please make that change, then do @bors r=@Veykril

ShoyuVanilla · 2024-08-29T13:23:46Z

@bors r=@Veykril

bors · 2024-08-29T13:23:48Z

📌 Commit 6520a43 has been approved by Veykril

It is now in the queue for this repository.

bors · 2024-08-29T13:24:57Z

⌛ Testing commit 6520a43 with merge 0ae42bd...

bors · 2024-08-29T13:38:54Z

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 0ae42bd to master...

ShoyuVanilla · 2024-08-29T13:55:39Z

This caused some regressions only in diesel. I'll find out why 🤔

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2024

ShoyuVanilla force-pushed the object-safety branch from e31991a to bdb9daa Compare August 8, 2024 13:09

ShoyuVanilla force-pushed the object-safety branch from bdb9daa to 1dbfb4c Compare August 8, 2024 15:31

ShoyuVanilla force-pushed the object-safety branch from 1dbfb4c to 059578b Compare August 17, 2024 13:31

ShoyuVanilla mentioned this pull request Aug 17, 2024

Error with rowan 0.15.16: protocol error: InternalError: request handler panicked: tree is mutable when asking for documentation in big crate graphs #17914

Open

ShoyuVanilla force-pushed the object-safety branch 2 times, most recently from 9fcb78e to b93159d Compare August 22, 2024 14:50

ShoyuVanilla force-pushed the object-safety branch 3 times, most recently from 1926ed3 to 9fe56f7 Compare August 25, 2024 15:47

ShoyuVanilla force-pushed the object-safety branch 2 times, most recently from 461e21a to fd8afe2 Compare August 25, 2024 16:43

Veykril reviewed Aug 26, 2024

View reviewed changes

crates/test-utils/src/minicore.rs Outdated Show resolved Hide resolved

Veykril reviewed Aug 26, 2024

View reviewed changes

crates/hir-ty/src/object_safety.rs Outdated Show resolved Hide resolved

ShoyuVanilla force-pushed the object-safety branch 3 times, most recently from dc50b0f to 33ebf59 Compare August 26, 2024 17:12

ShoyuVanilla force-pushed the object-safety branch from 33ebf59 to 9477836 Compare August 27, 2024 12:19

ShoyuVanilla commented Aug 27, 2024

View reviewed changes

crates/ide/src/hover/render.rs Show resolved Hide resolved

ShoyuVanilla commented Aug 27, 2024

View reviewed changes

ShoyuVanilla marked this pull request as ready for review August 27, 2024 12:28

Veykril reviewed Aug 27, 2024

View reviewed changes

crates/ide/src/hover/render.rs Outdated Show resolved Hide resolved

crates/ide/src/hover/render.rs Outdated Show resolved Hide resolved

crates/hir-ty/src/db.rs Outdated Show resolved Hide resolved

ShoyuVanilla force-pushed the object-safety branch 2 times, most recently from 19b38de to 19f6a3f Compare August 28, 2024 14:16

Veykril approved these changes Aug 29, 2024

View reviewed changes

feat: Implement object safety

6520a43

ShoyuVanilla force-pushed the object-safety branch from 19f6a3f to 6520a43 Compare August 29, 2024 13:22

bors merged commit 0ae42bd into rust-lang:master Aug 29, 2024

ShoyuVanilla deleted the object-safety branch August 29, 2024 13:39

bors mentioned this pull request Aug 29, 2024

internal: Lay basic ground work for standalone mbe tests #17967

Merged

ShoyuVanilla mentioned this pull request Aug 29, 2024

feat: Implement diagnostics for E0038 #18000

Open

	MethodViolationCode::StaticMethod => "static (no receiver parameter)",
	MethodViolationCode::StaticMethod => "missing a receiver",

	"has a method `{}` that is non dispatchable because of;\n// - ",
	"has a method `{}` that is non dispatchable because of:\n// - ",

	MethodViolationCode::AsyncFn => "async",
	MethodViolationCode::AsyncFn => "being async",

	MethodViolationCode::Generic => "a Generic parameter other than lifetime",
	MethodViolationCode::Generic => "a non-lifetime generic parameter",

	MethodViolationCode::UndispatchableReceiver => "the non dispatchable receiver type",
	MethodViolationCode::UndispatchableReceiver => "a non-dispatchable receiver type",

feat: Implement object safety and its hovering hint #17814

feat: Implement object safety and its hovering hint #17814

Uh oh!

Conversation

ShoyuVanilla commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Aug 8, 2024

Uh oh!

ShoyuVanilla commented Aug 10, 2024

Uh oh!

bors commented Aug 15, 2024

Uh oh!

bors commented Aug 23, 2024

Uh oh!

ShoyuVanilla commented Aug 25, 2024

Uh oh!

Uh oh!

Uh oh!

ShoyuVanilla commented Aug 26, 2024

Uh oh!

bors commented Aug 26, 2024

Uh oh!

bors commented Aug 27, 2024

Uh oh!

ShoyuVanilla Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ShoyuVanilla Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

ShoyuVanilla commented Aug 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Veykril Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

Veykril Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

Veykril Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

Veykril Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

Veykril Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

Veykril commented Aug 29, 2024

Uh oh!

bors commented Aug 29, 2024

Uh oh!

ShoyuVanilla commented Aug 29, 2024

Uh oh!

bors commented Aug 29, 2024

Uh oh!

bors commented Aug 29, 2024

Uh oh!

bors commented Aug 29, 2024

Uh oh!

ShoyuVanilla commented Aug 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ShoyuVanilla commented Aug 6, 2024 •

edited

Loading

ShoyuVanilla Aug 27, 2024 •

edited

Loading