-
Notifications
You must be signed in to change notification settings - Fork 681
Add an environment variable to let us exclude crate IDs from the recent downloads list #4649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7f42f42 to
2761002
Compare
|
would it be possible to filter by crate name instead? or is the name not available in that table? |
|
The query does join to the |
|
in that case I think you can start a test app with a random crate name in the new config value and then create that crate after the app has started, right? |
|
given that the particular crate now has almost 1/4 of the downloads of |
7e1c5fb to
8c3dd17
Compare
|
Good calls. Updated! |
|
☔ The latest upstream changes (presumably #4645) made this pull request unmergeable. Please resolve the merge conflicts. |
8c3dd17 to
bf912ec
Compare
|
looks great, thank you! one potential follow up: we allow the users to view the list of crates sorted by downloads too, but we don't exclude the crates there. I'm not sure how or if we should deal with that too. merging anyways since this is a good first step :) @bors r+ |
|
📌 Commit bf912ec has been approved by |
|
☀️ Test successful - checks-actions |
I haven't figured out a great way to add a test for this because I need to create a crate and get a crate ID and then change the app's config, and the test app doesn't easily have this... so I thought I'd throw up this change for discussion and see if anyone had better ideas.