Exclude crates from all time downloaded list too

Author: carols10cents

src/controllers/krate/metadata.rs

@@ -73,8 +73,13 @@ pub fn summary(req: &mut dyn RequestExt) -> EndpointResult {
         .select(selection)
         .limit(10)
         .load(&*conn)?;
-    let most_downloaded = crates
-        .left_join(recent_crate_downloads::table)
+
+    let mut most_downloaded_query = crates.left_join(recent_crate_downloads::table).into_boxed();
+    if !config.excluded_crate_names.is_empty() {
+        most_downloaded_query =
+            most_downloaded_query.filter(name.ne(all(&config.excluded_crate_names)));
+    }
+    let most_downloaded = most_downloaded_query
         .then_order_by(downloads.desc())
         .select(selection)
         .limit(10)

src/tests/krate/summary.rs

@@ -142,6 +142,10 @@ fn excluded_crate_id() {
 
     let json: SummaryResponse = anon.get("/api/v1/summary").good();
 
+    assert_eq!(json.most_downloaded.len(), 1);
+    assert_eq!(json.most_downloaded[0].name, "some_downloads");
+    assert_eq!(json.most_downloaded[0].downloads, 20);
+
     assert_eq!(json.most_recently_downloaded.len(), 1);
     assert_eq!(json.most_recently_downloaded[0].name, "some_downloads");
     assert_eq!(json.most_recently_downloaded[0].recent_downloads, Some(10));