Parity conversion and error handling cleanup
#403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Aren't we doing ecosystem-wide MSRV bump to 1.41.1? |
|
Sure thing. Perhaps we could have a label for 'will work once we bump MSRV' to help us queue these changes up and to save others checking what the CI fail is about? |
Kixunil
force-pushed
the
parity-error-handling
branch
2 times, most recently
from
7d66770 to
e0767d3
Compare
|
Spurious CI error |
|
Looks like CI is working again -- but PR still needs update if we're going to get it into this major version (which does not increase MSRV) |
|
ACK cf6badf aside from the |
This removes the deprecated `From` conversion and adds a new error type for the invalid parity error with a conversion to the catch-all `Error`.
Kixunil
force-pushed
the
parity-error-handling
branch
from
e0767d3 to
5acf6d2
Compare
|
Fixed (changed to |
apoelstra
approved these changes
Mar 1, 2022
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
…handling cleanup
5acf6d23d3636d88d628cb53306b37a8af81b133 `Parity` conversion and error handling cleanup (Martin Habovstiak)
Pull request description:
This removes the deprecated `From` conversion, replaces it with
`TryFrom`, and adds more convenience conversions. A new error type is
created for the invalid parity error with conversion to catch-all
`Error`.
This is intended for an API-breaking version.
ACKs for top commit:
apoelstra:
ACK 5acf6d23d3636d88d628cb53306b37a8af81b133
Tree-SHA512: 49b73fc90455c172012b46f36eafa7d256b940f4b431b4eedb577ab07d9402eae40af931e00b3c409bbe502dbcac064a742e874a5e8bedd8d0cbe92a468ae4f6
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
…handling cleanup
5acf6d23d3636d88d628cb53306b37a8af81b133 `Parity` conversion and error handling cleanup (Martin Habovstiak)
Pull request description:
This removes the deprecated `From` conversion, replaces it with
`TryFrom`, and adds more convenience conversions. A new error type is
created for the invalid parity error with conversion to catch-all
`Error`.
This is intended for an API-breaking version.
ACKs for top commit:
apoelstra:
ACK 5acf6d23d3636d88d628cb53306b37a8af81b133
Tree-SHA512: 49b73fc90455c172012b46f36eafa7d256b940f4b431b4eedb577ab07d9402eae40af931e00b3c409bbe502dbcac064a742e874a5e8bedd8d0cbe92a468ae4f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the deprecated
Fromconversion, replaces it withTryFrom, and adds more convenience conversions. A new error type iscreated for the invalid parity error with conversion to catch-all
Error.This is intended for an API-breaking version.