update libsecp to latest ersion; bump major version number #384

apoelstra · 2022-01-24T15:58:45Z

Should wait on merging until we get a minor release out with #382 and #376.

May also want to bundle #380 with this?

apoelstra · 2022-01-24T18:10:20Z

cc @real-or-random

real-or-random

utACK 6950253 I inspected the rust changes but I haven't reproduced the C subtree

real-or-random · 2022-01-24T18:40:52Z

secp256k1-sys/build.rs

    base_config.file("depend/secp256k1/contrib/lax_der_parsing.c")
+               .file("depend/secp256k1/src/precomputed_ecmult_gen.c")
+               .file("depend/secp256k1/src/precomputed_ecmult.c")


note: In upstream, we compile these to a separate object which is then linked to the actual library code. This saves compilation time in the common case that the code has changed but tables haven't. But it's probably not worth the hassle here because we never touch the C code here, not even during development.

dr-orlovsky · 2022-02-20T23:23:43Z

Is this ready to be merged to unblock miniscript progress towards taproot? (see rust-bitcoin/rust-miniscript#292 for details)

apoelstra · 2022-02-21T13:03:25Z

Rebased. But we still don't have #390 in.

apoelstra · 2022-02-23T18:53:42Z

Let's get #396 #401 #402 #403 and maybe #406 in.

Kixunil · 2022-02-23T19:51:35Z

Do we plan to change MSRV already or is it intended for later release?

apoelstra · 2022-02-23T20:46:38Z

@Kixunil later release. I'd like to get this major release into the upcoming rust-bitcoin major release, so I'm trying to keep it small (just new version of upstream and fixed Parity API)

Kixunil · 2022-02-24T11:01:31Z

OK, will change #403 to not require MSRV bump.

apoelstra · 2022-03-01T13:15:29Z

Rebased. Remaining:

Add CHANGELOG uppdate
@tcharding should we get Use fixed width serde impls for keys #406 into this release? I am tempted to say no because (a) it's not ready, and (b) it changes the serde serialization which is a controversial thing to do

tcharding · 2022-03-01T15:30:52Z

Let's leave it out, thanks for asking.

Kixunil · 2022-03-01T15:32:58Z

changes the serde serialization which is a controversial thing to do

Is it? One of my PRs did just that and nobody complained. :)

apoelstra · 2022-03-01T19:45:32Z

@Kixunil just in Parity, you mean? I'm ok with that since it's a new and fairly minor type.

Kixunil · 2022-03-01T20:00:29Z

Yes, OK.

apoelstra · 2022-03-02T22:23:30Z

Would like to get #410 in as well

Two API changes needed to be reflected: schnorrsig_sign and schnorrsig_verify. Also bump both Cargo.toml files

…CHECK We can no longer produce non-verification context objects, so instead produce an invalid public key.

6bcf3ea Add bitcoin-hashes-std features (Tobin Harding) 555833b Disable bitcoin_hashes default features (Tobin Harding) b6f169f Improve manifest whitespace (Tobin Harding) Pull request description: Currently we use default features for the `bitcoin_hashes` dependency, doing so breaks the `no-std` feature in `rust-bitcoin` because `std` is part of `bitcoin_hashes` default feature set. Disable `bitcoin_hashes` default features, no changes to `rust-bitcoin` are require after this change since we manually turn on `std` and `alloc` as part of the `std`/`no-std` features of `rust-bitcoin`. For other users of `rust-secp256k1` this is a breaking change but is unlikely to cause too much bother because `std` is so commonly used. This PR resolves an open [issue](#384) in `rust-bitcoin`, see issue for discussion. ACKs for top commit: apoelstra: ACK 6bcf3ea Tree-SHA512: 3cb83b67ba73b096f05cb5c98e1057c34cbf75208c626830a9c5050d3927c7dc6c13109e43c01701b1dfa7adfcfb6745bae6501f903be5976f6d1534fa9b3598

apoelstra · 2022-03-08T19:51:54Z

Rebased; added changelog; this is ready to go.

@elichai and/or @real-or-random can you ACK this?

real-or-random

ACK aa51638 I can't judge if the feature set is meaningful but this release PR is fine

sanket1729 · 2022-03-09T11:41:48Z

Thanks for this @real-or-random. This release would give us static contexts that help a lot in terms of code hygiene for downstream projects.

…ures 6bcf3ea0d0216d154b7a4955110dcb749935d588 Add bitcoin-hashes-std features (Tobin Harding) 555833b70f1ceaa6f3e5185330a1ee7cd810534f Disable bitcoin_hashes default features (Tobin Harding) b6f169f0837a6a43135f721bfb9371c3ddd01f3f Improve manifest whitespace (Tobin Harding) Pull request description: Currently we use default features for the `bitcoin_hashes` dependency, doing so breaks the `no-std` feature in `rust-bitcoin` because `std` is part of `bitcoin_hashes` default feature set. Disable `bitcoin_hashes` default features, no changes to `rust-bitcoin` are require after this change since we manually turn on `std` and `alloc` as part of the `std`/`no-std` features of `rust-bitcoin`. For other users of `rust-secp256k1` this is a breaking change but is unlikely to cause too much bother because `std` is so commonly used. This PR resolves an open [issue](rust-bitcoin/rust-secp256k1#384) in `rust-bitcoin`, see issue for discussion. ACKs for top commit: apoelstra: ACK 6bcf3ea0d0216d154b7a4955110dcb749935d588 Tree-SHA512: 3cb83b67ba73b096f05cb5c98e1057c34cbf75208c626830a9c5050d3927c7dc6c13109e43c01701b1dfa7adfcfb6745bae6501f903be5976f6d1534fa9b3598

…n; bump major version number aa516384dfff31c96bb11b3610a5d33c4f1c1bb1 update changelog for 0.22.0 (Andrew Poelstra) d06dd2023b27299b60165afea84c694c50e1e8fe update fuzzdummy API to match normal API (Andrew Poelstra) f3d48a298e4faca29889bad3623b445a3bff8db2 update "should terminate abnormally" test to trigger a different ARG_CHECK (Andrew Poelstra) 8294ea3f50f6de88f88b848c01eb60cab2a73241 secp256k1-sys: update upstream library (Andrew Poelstra) 2932179bd63eb5b7549a473c4e5c16656a81b5e2 secp256k1-sys: update secp256k1.h.patch (Andrew Poelstra) Pull request description: Should wait on merging until we get a minor release out with #382 and #376. May also want to bundle #380 with this? ACKs for top commit: real-or-random: ACK rust-bitcoin/rust-secp256k1@aa51638 I can't judge if the feature set is meaningful but this release PR is fine Tree-SHA512: e7f48b402378e280a034127f2de58d3127e04303a114f07f294fa3d00c0a083ae0d43375a8a74d226b13ea45fb3fde07d8450790e602bbf9581adc5fd8bc7d29

…ures 6bcf3ea0d0216d154b7a4955110dcb749935d588 Add bitcoin-hashes-std features (Tobin Harding) 555833b70f1ceaa6f3e5185330a1ee7cd810534f Disable bitcoin_hashes default features (Tobin Harding) b6f169f0837a6a43135f721bfb9371c3ddd01f3f Improve manifest whitespace (Tobin Harding) Pull request description: Currently we use default features for the `bitcoin_hashes` dependency, doing so breaks the `no-std` feature in `rust-bitcoin` because `std` is part of `bitcoin_hashes` default feature set. Disable `bitcoin_hashes` default features, no changes to `rust-bitcoin` are require after this change since we manually turn on `std` and `alloc` as part of the `std`/`no-std` features of `rust-bitcoin`. For other users of `rust-secp256k1` this is a breaking change but is unlikely to cause too much bother because `std` is so commonly used. This PR resolves an open [issue](rust-bitcoin/rust-secp256k1#384) in `rust-bitcoin`, see issue for discussion. ACKs for top commit: apoelstra: ACK 6bcf3ea0d0216d154b7a4955110dcb749935d588 Tree-SHA512: 3cb83b67ba73b096f05cb5c98e1057c34cbf75208c626830a9c5050d3927c7dc6c13109e43c01701b1dfa7adfcfb6745bae6501f903be5976f6d1534fa9b3598

…n; bump major version number aa516384dfff31c96bb11b3610a5d33c4f1c1bb1 update changelog for 0.22.0 (Andrew Poelstra) d06dd2023b27299b60165afea84c694c50e1e8fe update fuzzdummy API to match normal API (Andrew Poelstra) f3d48a298e4faca29889bad3623b445a3bff8db2 update "should terminate abnormally" test to trigger a different ARG_CHECK (Andrew Poelstra) 8294ea3f50f6de88f88b848c01eb60cab2a73241 secp256k1-sys: update upstream library (Andrew Poelstra) 2932179bd63eb5b7549a473c4e5c16656a81b5e2 secp256k1-sys: update secp256k1.h.patch (Andrew Poelstra) Pull request description: Should wait on merging until we get a minor release out with #382 and #376. May also want to bundle #380 with this? ACKs for top commit: real-or-random: ACK rust-bitcoin/rust-secp256k1@aa51638 I can't judge if the feature set is meaningful but this release PR is fine Tree-SHA512: e7f48b402378e280a034127f2de58d3127e04303a114f07f294fa3d00c0a083ae0d43375a8a74d226b13ea45fb3fde07d8450790e602bbf9581adc5fd8bc7d29

real-or-random previously approved these changes Jan 24, 2022

View reviewed changes

real-or-random linked an issue Jan 25, 2022 that may be closed by this pull request

Update to latest master to get support for static verification contexts #378

Closed

sanket1729 mentioned this pull request Feb 1, 2022

Add tr descriptor rust-bitcoin/rust-miniscript#278

Merged

apoelstra mentioned this pull request Feb 9, 2022

bump version to 0.21.3 #390

Merged

apoelstra dismissed real-or-random’s stale review via a7bb5fb February 21, 2022 13:02

apoelstra force-pushed the 2022-01--secp-update branch from 6950253 to a7bb5fb Compare February 21, 2022 13:02

apoelstra force-pushed the 2022-01--secp-update branch from a7bb5fb to 9a0cf1f Compare March 1, 2022 13:14

tcharding mentioned this pull request Mar 1, 2022

Bitcoin hashes no default features #410

Merged

apoelstra added 5 commits March 8, 2022 19:44

secp256k1-sys: update secp256k1.h.patch

2932179

secp256k1-sys: update upstream library

8294ea3

Two API changes needed to be reflected: schnorrsig_sign and schnorrsig_verify. Also bump both Cargo.toml files

update "should terminate abnormally" test to trigger a different ARG_…

f3d48a2

…CHECK We can no longer produce non-verification context objects, so instead produce an invalid public key.

update fuzzdummy API to match normal API

d06dd20

update changelog for 0.22.0

aa51638

apoelstra force-pushed the 2022-01--secp-update branch 2 times, most recently from 7fd7cba to aa51638 Compare March 8, 2022 19:50

real-or-random approved these changes Mar 9, 2022

View reviewed changes

sanket1729 mentioned this pull request Mar 9, 2022

7.0 RC1 release rust-bitcoin/rust-miniscript#292

Closed

apoelstra merged commit 50b7c25 into rust-bitcoin:master Mar 9, 2022

apoelstra deleted the 2022-01--secp-update branch March 9, 2022 12:58

update libsecp to latest ersion; bump major version number #384

update libsecp to latest ersion; bump major version number #384

Uh oh!

Conversation

apoelstra commented Jan 24, 2022

Uh oh!

apoelstra commented Jan 24, 2022

Uh oh!

real-or-random left a comment

Choose a reason for hiding this comment

Uh oh!

real-or-random Jan 24, 2022

Choose a reason for hiding this comment

Uh oh!

dr-orlovsky commented Feb 20, 2022

Uh oh!

apoelstra commented Feb 21, 2022

Uh oh!

apoelstra commented Feb 23, 2022

Uh oh!

Kixunil commented Feb 23, 2022

Uh oh!

apoelstra commented Feb 23, 2022

Uh oh!

Kixunil commented Feb 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

apoelstra commented Mar 1, 2022

Uh oh!

tcharding commented Mar 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kixunil commented Mar 1, 2022

Uh oh!

apoelstra commented Mar 1, 2022

Uh oh!

Kixunil commented Mar 1, 2022

Uh oh!

apoelstra commented Mar 2, 2022

Uh oh!

apoelstra commented Mar 8, 2022

Uh oh!

real-or-random left a comment

Choose a reason for hiding this comment

Uh oh!

sanket1729 commented Mar 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Kixunil commented Feb 24, 2022 •

edited

Loading

tcharding commented Mar 1, 2022 •

edited

Loading